Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-05 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:21 AM wrote: > On Fri, 2018-11-02 at 20:12 +0200, Andy Shevchenko wrote: > > On Fri, Nov 2, 2018 at 6:12 AM Ayman Bagabas > > wrote: Takashi explained me, that is the way sound driver are using the external symbols, so, follow his suggestion. > > > +static int (*huawei_

Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-02 Thread ayman . bagabas
On Fri, 2018-11-02 at 20:12 +0200, Andy Shevchenko wrote: > On Fri, Nov 2, 2018 at 6:12 AM Ayman Bagabas > wrote: > > > > Some of Huawei laptops come with a LED in the mic mute key. This > > patch > > enables and disable this LED accordingly. > > --- a/drivers/platform/x86/huawei_wmi.c > > +++ b/

Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 2, 2018 at 8:30 PM Takashi Iwai wrote: > On Fri, 02 Nov 2018 19:12:44 +0100, > Andy Shevchenko wrote: > > > > > + if (action == HDA_FIXUP_ACT_PROBE) { > > > + if (!huawei_wmi_micmute_led_set_func) > > > + huawei_wmi_micmute_led_set_func = > >

Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-02 Thread Takashi Iwai
On Fri, 02 Nov 2018 19:12:44 +0100, Andy Shevchenko wrote: > > > + if (action == HDA_FIXUP_ACT_PROBE) { > > + if (!huawei_wmi_micmute_led_set_func) > > + huawei_wmi_micmute_led_set_func = > > symbol_request(huawei_wmi_micmute_led_set); > > +

Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 2, 2018 at 6:12 AM Ayman Bagabas wrote: > > Some of Huawei laptops come with a LED in the mic mute key. This patch > enables and disable this LED accordingly. > --- a/drivers/platform/x86/huawei_wmi.c > +++ b/drivers/platform/x86/huawei_wmi.c > @@ -26,6 +26,7 @@ > #include > #inclu

[PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED

2018-11-01 Thread Ayman Bagabas
Some of Huawei laptops come with a LED in the mic mute key. This patch enables and disable this LED accordingly. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei_wmi.c | 1 + include/linux/huawei_wmi.h| 7 + sound/pci/hda/huawei_wmi_helper.c | 48 +++