Re: [PATCH v2 3/3] ARM: da850: fix da850_set_pll0rate()

2016-12-05 Thread Sekhar Nori
On Friday 02 December 2016 09:08 PM, Bartosz Golaszewski wrote: > This function is broken - its second argument is an index to the freq > table, not the requested clock rate in Hz. It leads to an oops when > called from clk_set_rate() since this argument isn't bounds checked > either. > > Fix it b

Re: [PATCH v2 3/3] ARM: da850: fix da850_set_pll0rate()

2016-12-05 Thread Bartosz Golaszewski
2016-12-05 9:45 GMT+01:00 Sekhar Nori : > On Friday 02 December 2016 09:08 PM, Bartosz Golaszewski wrote: >> This function is broken - its second argument is an index to the freq >> table, not the requested clock rate in Hz. It leads to an oops when >> called from clk_set_rate() since this argument

Re: [PATCH v2 3/3] ARM: da850: fix da850_set_pll0rate()

2016-12-04 Thread Viresh Kumar
Good to see you again Bartosz :) On 02-12-16, 16:38, Bartosz Golaszewski wrote: > This function is broken - its second argument is an index to the freq > table, not the requested clock rate in Hz. It leads to an oops when > called from clk_set_rate() since this argument isn't bounds checked > eith

[PATCH v2 3/3] ARM: da850: fix da850_set_pll0rate()

2016-12-02 Thread Bartosz Golaszewski
This function is broken - its second argument is an index to the freq table, not the requested clock rate in Hz. It leads to an oops when called from clk_set_rate() since this argument isn't bounds checked either. Fix it by iterating over the array of supported frequencies and selecting a one that