Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

2020-10-09 Thread Pavel Machek
Hi! > Thank you for the review. Note I'm LED maintainer. > > > + leds { > > > + compatible = "gpio-leds"; > > > + > > > + sdhi2_led { > > > + label = "sdio-led"; > > > > This should use appropriate label... probably mmc1:green:activity. > > > $

Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

2020-10-09 Thread Lad, Prabhakar
Hi Pavel, Thank you for the review. On Fri, Oct 9, 2020 at 8:33 AM Pavel Machek wrote: > > Hi! > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > > @@ -63,6 +63,16 @@ > > enable-gpios = < 11 GPIO_ACTIVE_HIGH>; > > }; > > > > + leds { > > + compatible =

Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

2020-10-09 Thread Pavel Machek
Hi! > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -63,6 +63,16 @@ > enable-gpios = < 11 GPIO_ACTIVE_HIGH>; > }; > > + leds { > + compatible = "gpio-leds"; > + > + sdhi2_led { > + label = "sdio-led"; This should use

Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

2020-09-10 Thread Geert Uytterhoeven
On Mon, Sep 7, 2020 at 5:56 PM Lad Prabhakar wrote: > Add support for LED trigger on SD2 interface. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson > Reviewed-by: Geert Uytterhoeven Thanks for the update, will queue in renesas-devel for v5.10. Gr{oetje,eeting}s,

[PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

2020-09-07 Thread Lad Prabhakar
Add support for LED trigger on SD2 interface. Signed-off-by: Lad Prabhakar Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven --- arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts