Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-06-01 Thread Viresh Kumar
On 30-05-16, 09:35, Steve Muckle wrote: > The text above (the second sentence) seems okay to me in that it > mentions remote updates are not currently supported. Let me know if > there is specific text you would like included. Perhaps I got confused between cover-letter and this log. Leave that. I

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-31 Thread Peter Zijlstra
On Mon, May 30, 2016 at 09:02:33PM +0530, Viresh Kumar wrote: > But this is something that is fundamentally broken for now. The user writes > updates the policy->max/min, we return the call to the user thinks that it has IMO the presence of these user min/max files is the broken part.

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Wanpeng Li
2016-05-30 22:25 GMT+08:00 Rafael J. Wysocki : > On Mon, May 30, 2016 at 12:18 PM, Viresh Kumar > wrote: >> On 29-05-16, 02:40, Rafael J. Wysocki wrote: >>> I can't really parse the above question, so I'm not going to try to >>> answer it. :-) >> >> Sorry about that :( >> >> IOW, I think that we

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Rafael J. Wysocki
On Mon, May 30, 2016 at 5:32 PM, Viresh Kumar wrote: > I clearly missed the !policy->fast_switch_enabled check in sugov_limit() and > so > the confusion. > > On 30-05-16, 16:25, Rafael J. Wysocki wrote: >> On Mon, May 30, 2016 at 12:18 PM, Viresh Kumar >> wrote: >> > Suppose this is the current

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Steve Muckle
On Fri, May 27, 2016 at 01:41:02PM +0800, Wanpeng Li wrote: > 2016-05-26 10:53 GMT+08:00 Steve Muckle : > > The slow-path frequency transition path is relatively expensive as it > > requires waking up a thread to do work. Should support be added for > > remote CPU cpufreq updates that is also expen

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Steve Muckle
On Thu, May 26, 2016 at 12:46:29PM +0530, Viresh Kumar wrote: > On 25-05-16, 19:53, Steve Muckle wrote: > > The slow-path frequency transition path is relatively expensive as it > > requires waking up a thread to do work. Should support be added for > > remote CPU cpufreq updates that is also expen

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Viresh Kumar
I clearly missed the !policy->fast_switch_enabled check in sugov_limit() and so the confusion. On 30-05-16, 16:25, Rafael J. Wysocki wrote: > On Mon, May 30, 2016 at 12:18 PM, Viresh Kumar > wrote: > > Suppose this is the current range of frequencies supported by a > > driver: 200, 400, 600, 800

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Rafael J. Wysocki
On Mon, May 30, 2016 at 12:18 PM, Viresh Kumar wrote: > On 29-05-16, 02:40, Rafael J. Wysocki wrote: >> I can't really parse the above question, so I'm not going to try to >> answer it. :-) > > Sorry about that :( > > IOW, I think that we should make this change into the sched-governor (I will > s

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-30 Thread Viresh Kumar
On 29-05-16, 02:40, Rafael J. Wysocki wrote: > I can't really parse the above question, so I'm not going to try to > answer it. :-) Sorry about that :( IOW, I think that we should make this change into the sched-governor (I will send a patch separately if you agree to this): diff --git a/kernel/

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-28 Thread Rafael J. Wysocki
On Thu, May 26, 2016 at 9:16 AM, Viresh Kumar wrote: > On 25-05-16, 19:53, Steve Muckle wrote: >> The slow-path frequency transition path is relatively expensive as it >> requires waking up a thread to do work. Should support be added for >> remote CPU cpufreq updates that is also expensive since

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-26 Thread Wanpeng Li
2016-05-26 10:53 GMT+08:00 Steve Muckle : > The slow-path frequency transition path is relatively expensive as it > requires waking up a thread to do work. Should support be added for > remote CPU cpufreq updates that is also expensive since it requires an > IPI. These activities should be avoided

Re: [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-26 Thread Viresh Kumar
On 25-05-16, 19:53, Steve Muckle wrote: > The slow-path frequency transition path is relatively expensive as it > requires waking up a thread to do work. Should support be added for > remote CPU cpufreq updates that is also expensive since it requires an > IPI. These activities should be avoided if

[PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency

2016-05-25 Thread Steve Muckle
The slow-path frequency transition path is relatively expensive as it requires waking up a thread to do work. Should support be added for remote CPU cpufreq updates that is also expensive since it requires an IPI. These activities should be avoided if they are not necessary. To that end, calculate