Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Amir Goldstein
On Tue, May 9, 2017 at 10:35 AM, Richard Weinberger wrote: > Amir, > > Am 09.05.2017 um 09:08 schrieb Amir Goldstein: >>> Then we can queue this patch for 4.13. >>> Please resend and make sure it addresses everything what was also >>> suggested for the xfs s_uuid patch. >>> >> >>

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Amir Goldstein
On Tue, May 9, 2017 at 10:35 AM, Richard Weinberger wrote: > Amir, > > Am 09.05.2017 um 09:08 schrieb Amir Goldstein: >>> Then we can queue this patch for 4.13. >>> Please resend and make sure it addresses everything what was also >>> suggested for the xfs s_uuid patch. >>> >> >> Just to be

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Oleksij Rempel
On 05/09/2017 09:08 AM, Amir Goldstein wrote: On Tue, May 9, 2017 at 10:01 AM, Richard Weinberger wrote: Oleksij, Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: If VFS maintainers are fine with that, I'll take it. From UBIFS' POV it does not matter much.

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Oleksij Rempel
On 05/09/2017 09:08 AM, Amir Goldstein wrote: On Tue, May 9, 2017 at 10:01 AM, Richard Weinberger wrote: Oleksij, Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: If VFS maintainers are fine with that, I'll take it. From UBIFS' POV it does not matter much. :-) Ping to

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Richard Weinberger
Amir, Am 09.05.2017 um 09:08 schrieb Amir Goldstein: >> Then we can queue this patch for 4.13. >> Please resend and make sure it addresses everything what was also >> suggested for the xfs s_uuid patch. >> > > Just to be clear, the xfs s_uuid patch is just a memcpy, > no different from Oleksij's

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Richard Weinberger
Amir, Am 09.05.2017 um 09:08 schrieb Amir Goldstein: >> Then we can queue this patch for 4.13. >> Please resend and make sure it addresses everything what was also >> suggested for the xfs s_uuid patch. >> > > Just to be clear, the xfs s_uuid patch is just a memcpy, > no different from Oleksij's

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Amir Goldstein
On Tue, May 9, 2017 at 10:01 AM, Richard Weinberger wrote: > > Oleksij, > > Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: > >> > >> If VFS maintainers are fine with that, I'll take it. > >> From UBIFS' POV it does not matter much. :-) > >> > >> > >> Ping to

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Amir Goldstein
On Tue, May 9, 2017 at 10:01 AM, Richard Weinberger wrote: > > Oleksij, > > Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: > >> > >> If VFS maintainers are fine with that, I'll take it. > >> From UBIFS' POV it does not matter much. :-) > >> > >> > >> Ping to VFS maintainers? >

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Richard Weinberger
Oleksij, Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: >> >> If VFS maintainers are fine with that, I'll take it. >> From UBIFS' POV it does not matter much. :-) >> >> >> Ping to VFS maintainers? >> >> >> What ping? Al made it clear that a flag is not needed. >> BTW, xfs

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-09 Thread Richard Weinberger
Oleksij, Am 09.05.2017 um 07:52 schrieb Oleksij Rempel: >> >> If VFS maintainers are fine with that, I'll take it. >> From UBIFS' POV it does not matter much. :-) >> >> >> Ping to VFS maintainers? >> >> >> What ping? Al made it clear that a flag is not needed. >> BTW, xfs

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-08 Thread Oleksij Rempel
On 05/09/2017 07:37 AM, Amir Goldstein wrote: On Tue, May 9, 2017 at 7:13 AM, Oleksij Rempel > wrote: On 05/02/2017 09:37 AM, Richard Weinberger wrote: Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein:

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-08 Thread Oleksij Rempel
On 05/09/2017 07:37 AM, Amir Goldstein wrote: On Tue, May 9, 2017 at 7:13 AM, Oleksij Rempel mailto:o...@pengutronix.de>> wrote: On 05/02/2017 09:37 AM, Richard Weinberger wrote: Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein: On Fri, Apr 28, 2017

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-08 Thread Oleksij Rempel
On 05/02/2017 09:37 AM, Richard Weinberger wrote: Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein: On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :)

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-08 Thread Oleksij Rempel
On 05/02/2017 09:37 AM, Richard Weinberger wrote: Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein: On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :) I'll not do

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Richard Weinberger
Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein: > On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: >> Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :) >>> >>> I'll not do it for you. ;) >> >>

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Richard Weinberger
Amir, Am 02.05.2017 um 09:19 schrieb Amir Goldstein: > On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: >> Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :) >>> >>> I'll not do it for you. ;) >> >> Please also see

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Artem Bityutskiy
On Tue, 2017-04-11 at 22:43 +0200, Richard Weinberger wrote: > Makes sense. > > Artem, do you remember why UBIFS didn't set s_uuid in first place? Just did not notice it I think.

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Artem Bityutskiy
On Tue, 2017-04-11 at 22:43 +0200, Richard Weinberger wrote: > Makes sense. > > Artem, do you remember why UBIFS didn't set s_uuid in first place? Just did not notice it I think.

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Amir Goldstein
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: > Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >>> So, if some flag should be implemented, who should do it? :) >> >> I'll not do it for you. ;) > > Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-02 Thread Amir Goldstein
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: > Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >>> So, if some flag should be implemented, who should do it? :) >> >> I'll not do it for you. ;) > > Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2 > Richard,

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-01 Thread Oleksij Rempel
On 04/28/2017 10:53 AM, Amir Goldstein wrote: On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :) I'll not do it for you. ;) Please also see

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-05-01 Thread Oleksij Rempel
On 04/28/2017 10:53 AM, Amir Goldstein wrote: On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: Am 24.04.2017 um 17:47 schrieb Richard Weinberger: So, if some flag should be implemented, who should do it? :) I'll not do it for you. ;) Please also see

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-28 Thread Amir Goldstein
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: > Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >>> So, if some flag should be implemented, who should do it? :) >> >> I'll not do it for you. ;) > > Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-28 Thread Amir Goldstein
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote: > Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >>> So, if some flag should be implemented, who should do it? :) >> >> I'll not do it for you. ;) > > Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2 > Perhaps you

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-27 Thread Richard Weinberger
Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >> So, if some flag should be implemented, who should do it? :) > > I'll not do it for you. ;) Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2 Thanks, //richard

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-27 Thread Richard Weinberger
Am 24.04.2017 um 17:47 schrieb Richard Weinberger: >> So, if some flag should be implemented, who should do it? :) > > I'll not do it for you. ;) Please also see http://marc.info/?l=linux-fsdevel=149327990608749=2 Thanks, //richard

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-24 Thread Richard Weinberger
Oleksij, Am 12.04.2017 um 09:15 schrieb Oleksij Rempel: > On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote: >> On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: >>> Artem, do you remember why UBIFS didn't set s_uuid in first place? >> >> It's an extremely odd

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-24 Thread Richard Weinberger
Oleksij, Am 12.04.2017 um 09:15 schrieb Oleksij Rempel: > On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote: >> On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: >>> Artem, do you remember why UBIFS didn't set s_uuid in first place? >> >> It's an extremely odd

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-12 Thread Oleksij Rempel
On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote: > On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > > Artem, do you remember why UBIFS didn't set s_uuid in first place? > > It's an extremely odd field - only a hand full of file systems set it > (e.g. XFS

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-12 Thread Oleksij Rempel
On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote: > On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > > Artem, do you remember why UBIFS didn't set s_uuid in first place? > > It's an extremely odd field - only a hand full of file systems set it > (e.g. XFS

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Christoph Hellwig
On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > Artem, do you remember why UBIFS didn't set s_uuid in first place? It's an extremely odd field - only a hand full of file systems set it (e.g. XFS doesn't, although according to Mimi IMA supports XFS), and it's never even used

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Christoph Hellwig
On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > Artem, do you remember why UBIFS didn't set s_uuid in first place? It's an extremely odd field - only a hand full of file systems set it (e.g. XFS doesn't, although according to Mimi IMA supports XFS), and it's never even used

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Richard Weinberger
Oleksij, Am 11.04.2017 um 11:50 schrieb Oleksij Rempel: > From: Steffen Trumtrar > > This is need to provide uuid based integrity functionlity for: > imy_policy (fsuuid option) and evmctl (--uuid option). > > Signed-off-by: Steffen Trumtrar

Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Richard Weinberger
Oleksij, Am 11.04.2017 um 11:50 schrieb Oleksij Rempel: > From: Steffen Trumtrar > > This is need to provide uuid based integrity functionlity for: > imy_policy (fsuuid option) and evmctl (--uuid option). > > Signed-off-by: Steffen Trumtrar > Signed-off-by: Oleksij Rempel > --- >

[PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Oleksij Rempel
From: Steffen Trumtrar This is need to provide uuid based integrity functionlity for: imy_policy (fsuuid option) and evmctl (--uuid option). Signed-off-by: Steffen Trumtrar Signed-off-by: Oleksij Rempel ---

[PATCH v2 3/3] fs: ubifs: set s_uuid in super block

2017-04-11 Thread Oleksij Rempel
From: Steffen Trumtrar This is need to provide uuid based integrity functionlity for: imy_policy (fsuuid option) and evmctl (--uuid option). Signed-off-by: Steffen Trumtrar Signed-off-by: Oleksij Rempel --- fs/ubifs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git