Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

2016-02-02 Thread Stefan Agner
Hi Julia, On 2016-01-29 23:06, Julia Lawall wrote: > I haven't checked the entire context, but it look suspicious to have the > kfree in the remove function and not in the probe function. Oh, yes, clearly an error I introduced. Will take a look at that. > > Unrlatedly, do the probe and remove f

Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

2016-02-01 Thread Rob Herring
On Fri, Jan 29, 2016 at 03:48:15PM -0800, Stefan Agner wrote: > Add device tree support for the I2C and SPI variant of AD7879(-1). > This allows to specify the touchscreen controller as a I2C client > node or SPI slave device. Most of the options available in platform > data are also available as d

Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

2016-01-29 Thread Julia Lawall
I haven't checked the entire context, but it look suspicious to have the kfree in the remove function and not in the probe function. Unrlatedly, do the probe and remove functions really needed to be exported? julia On Sat, 30 Jan 2016, kbuild test robot wrote: > > Hi Stefan, > > [auto build

[PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

2016-01-29 Thread Stefan Agner
Add device tree support for the I2C and SPI variant of AD7879(-1). This allows to specify the touchscreen controller as a I2C client node or SPI slave device. Most of the options available in platform data are also available as device tree properties, the only exception being GPIO capabilities, whi