Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tejun Heo
On Wed, Aug 01, 2018 at 05:32:01PM -0700, Roman Gushchin wrote: > For some workloads an intervention from the OOM killer > can be painful. Killing a random task can bring > the workload into an inconsistent state. For patches 1-3, Acked-by: Tejun Heo Thanks. -- tejun

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tejun Heo
On Wed, Aug 01, 2018 at 05:32:01PM -0700, Roman Gushchin wrote: > For some workloads an intervention from the OOM killer > can be painful. Killing a random task can bring > the workload into an inconsistent state. For patches 1-3, Acked-by: Tejun Heo Thanks. -- tejun

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Roman Gushchin
On Thu, Aug 02, 2018 at 07:53:13PM +0900, Tetsuo Handa wrote: > On 2018/08/02 9:32, Roman Gushchin wrote: > > For some workloads an intervention from the OOM killer > > can be painful. Killing a random task can bring > > the workload into an inconsistent state. > > > > Historically, there are two

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Roman Gushchin
On Thu, Aug 02, 2018 at 07:53:13PM +0900, Tetsuo Handa wrote: > On 2018/08/02 9:32, Roman Gushchin wrote: > > For some workloads an intervention from the OOM killer > > can be painful. Killing a random task can bring > > the workload into an inconsistent state. > > > > Historically, there are two

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Michal Hocko
On Thu 02-08-18 20:53:14, Tetsuo Handa wrote: > On 2018/08/02 20:21, Michal Hocko wrote: > > On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: > >> On 2018/08/02 9:32, Roman Gushchin wrote: > > [...] > >>> +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, > >>> +

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Michal Hocko
On Thu 02-08-18 20:53:14, Tetsuo Handa wrote: > On 2018/08/02 20:21, Michal Hocko wrote: > > On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: > >> On 2018/08/02 9:32, Roman Gushchin wrote: > > [...] > >>> +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, > >>> +

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tetsuo Handa
On 2018/08/02 20:21, Michal Hocko wrote: > On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: >> On 2018/08/02 9:32, Roman Gushchin wrote: > [...] >>> +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, >>> + struct mem_cgroup *oom_domain) >>>

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tetsuo Handa
On 2018/08/02 20:21, Michal Hocko wrote: > On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: >> On 2018/08/02 9:32, Roman Gushchin wrote: > [...] >>> +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, >>> + struct mem_cgroup *oom_domain) >>>

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Michal Hocko
On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: > On 2018/08/02 9:32, Roman Gushchin wrote: [...] > > +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, > > + struct mem_cgroup *oom_domain) > > +{ > > + struct mem_cgroup *oom_group =

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Michal Hocko
On Thu 02-08-18 19:53:13, Tetsuo Handa wrote: > On 2018/08/02 9:32, Roman Gushchin wrote: [...] > > +struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim, > > + struct mem_cgroup *oom_domain) > > +{ > > + struct mem_cgroup *oom_group =

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tetsuo Handa
On 2018/08/02 9:32, Roman Gushchin wrote: > For some workloads an intervention from the OOM killer > can be painful. Killing a random task can bring > the workload into an inconsistent state. > > Historically, there are two common solutions for this > problem: > 1) enabling panic_on_oom, > 2)

Re: [PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-02 Thread Tetsuo Handa
On 2018/08/02 9:32, Roman Gushchin wrote: > For some workloads an intervention from the OOM killer > can be painful. Killing a random task can bring > the workload into an inconsistent state. > > Historically, there are two common solutions for this > problem: > 1) enabling panic_on_oom, > 2)

[PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-01 Thread Roman Gushchin
For some workloads an intervention from the OOM killer can be painful. Killing a random task can bring the workload into an inconsistent state. Historically, there are two common solutions for this problem: 1) enabling panic_on_oom, 2) using a userspace daemon to monitor OOMs and kill all

[PATCH v2 3/3] mm, oom: introduce memory.oom.group

2018-08-01 Thread Roman Gushchin
For some workloads an intervention from the OOM killer can be painful. Killing a random task can bring the workload into an inconsistent state. Historically, there are two common solutions for this problem: 1) enabling panic_on_oom, 2) using a userspace daemon to monitor OOMs and kill all