RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
rd Leitner ; net...@vger.kernel.org; linux- >>> ker...@vger.kernel.org >>> Subject: Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for >>> SMSC >>> LAN8710/20 >>> >>> >>> On 11/20/2017 10:47 AM, Andy Duan wrote: >>>&g

Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Geert Uytterhoeven
Hi Richard, On Mon, Nov 20, 2017 at 2:21 PM, Richard Leitner wrote: > On 11/20/2017 02:13 PM, Geert Uytterhoeven wrote: >> On Mon, Nov 20, 2017 at 1:55 PM, Richard Leitner >> wrote: >>> On 11/20/2017 11:35 AM, Andy Duan wrote: 3. add reset gpio descriptor for common phy device driver. >>> >

Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Richard Leitner
On 11/20/2017 02:13 PM, Geert Uytterhoeven wrote: > Hi Richard, > > On Mon, Nov 20, 2017 at 1:55 PM, Richard Leitner > wrote: >> On 11/20/2017 11:35 AM, Andy Duan wrote: >>> 3. add reset gpio descriptor for common phy device driver. >> >> ... if I understood it correctly the patch called "Teach

Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Geert Uytterhoeven
Hi Richard, On Mon, Nov 20, 2017 at 1:55 PM, Richard Leitner wrote: > On 11/20/2017 11:35 AM, Andy Duan wrote: >> 3. add reset gpio descriptor for common phy device driver. > > ... if I understood it correctly the patch called "Teach phylib > hard-resetting devices" by Geert and Sergei is exactly

Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Richard Leitner
y Duan ; >>>> and...@lunn.ch >>>> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> richard.leit...@skidata.com >>>> Subject: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for >>>> SMSC >>>> LAN8710/20 >>>>

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
From: Richard Leitner Sent: Monday, November 20, 2017 5:57 PM >To: Andy Duan ; f.faine...@gmail.com; >and...@lunn.ch >Cc: Richard Leitner ; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC >LAN871

Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Richard Leitner
>> Subject: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC >> LAN8710/20 >> >> From: Richard Leitner >> >> Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning >> the refclk on and off again during operation (according to the

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
From: Richard Leitner Sent: Monday, November 20, 2017 4:34 PM >To: f.faine...@gmail.com; Andy Duan ; >and...@lunn.ch >Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; >richard.leit...@skidata.com >Subject: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC >

[PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Richard Leitner
From: Richard Leitner Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning the refclk on and off again during operation (according to their datasheet). Nonetheless exactly this behaviour was introduced for power saving reasons by commit e8fcfcd5684a ("net: fec: optimize the cloc