Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-09-09 Thread Hannes Reinecke
On 8/31/19 12:24 AM, James Smart wrote: > On 8/30/2019 2:07 PM, Sagi Grimberg wrote: >> >>> Yes we do, userspace should use it to order events.  Does udev not >>> handle that properly today? >> >> The problem is not ordering of events, its really about the fact that >> the chard

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 06:35:30PM -0700, Sagi Grimberg wrote: > > > > Still don't understand how this is ok... > > > > > > I have /dev/nvme0 represents a network endpoint that I would discover > > > from, it is raising me an event to do a discovery operation (namely to > > > issue an ioctl to it

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-09-03 Thread Sagi Grimberg
Still don't understand how this is ok... I have /dev/nvme0 represents a network endpoint that I would discover from, it is raising me an event to do a discovery operation (namely to issue an ioctl to it) so my udev code calls a systemd script. By the time I actually get to do that, /dev/nvme0

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-09-02 Thread Greg Kroah-Hartman
On Fri, Aug 30, 2019 at 11:14:39AM -0700, Sagi Grimberg wrote: > > > > > > > > You are correct that this information can be derived from sysfs, > > > > > > > but the > > > > > > > main reason why we add these here, is because in udev rule we > > > > > > > can't > > > > > > > just go ahead and st

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-30 Thread James Smart
On 8/30/2019 2:07 PM, Sagi Grimberg wrote: Yes we do, userspace should use it to order events.  Does udev not handle that properly today? The problem is not ordering of events, its really about the fact that the chardev can be removed and reallocated for a different controller (could be a com

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-30 Thread Sagi Grimberg
Yes we do, userspace should use it to order events.  Does udev not handle that properly today? The problem is not ordering of events, its really about the fact that the chardev can be removed and reallocated for a different controller (could be a completely different discovery controller) by

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-30 Thread James Smart
On 8/30/2019 11:08 AM, Sagi Grimberg wrote: Yes we do, userspace should use it to order events.  Does udev not handle that properly today? The problem is not ordering of events, its really about the fact that the chardev can be removed and reallocated for a different controller (could be a co

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-30 Thread Sagi Grimberg
You are correct that this information can be derived from sysfs, but the main reason why we add these here, is because in udev rule we can't just go ahead and start looking these up and parsing these.. We could send the discovery aen with NVME_CTRL_NAME and have then have systemd run something

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-30 Thread Sagi Grimberg
Yes we do, userspace should use it to order events. Does udev not handle that properly today? The problem is not ordering of events, its really about the fact that the chardev can be removed and reallocated for a different controller (could be a completely different discovery controller) by

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-29 Thread Greg Kroah-Hartman
On Thu, Aug 29, 2019 at 11:21:02AM -0700, Sagi Grimberg wrote: > > > > > > You are correct that this information can be derived from sysfs, but > > > > > the > > > > > main reason why we add these here, is because in udev rule we can't > > > > > just go ahead and start looking these up and parsin

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-29 Thread Christoph Hellwig
On Thu, Aug 29, 2019 at 11:21:02AM -0700, Sagi Grimberg wrote: >> Yes we do, userspace should use it to order events. Does udev not >> handle that properly today? > > The problem is not ordering of events, its really about the fact that > the chardev can be removed and reallocated for a different

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-29 Thread Sagi Grimberg
You are correct that this information can be derived from sysfs, but the main reason why we add these here, is because in udev rule we can't just go ahead and start looking these up and parsing these.. We could send the discovery aen with NVME_CTRL_NAME and have then have systemd run something

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-26 Thread Greg Kroah-Hartman
On Mon, Aug 26, 2019 at 08:56:39AM +0200, Christoph Hellwig wrote: > On Thu, Aug 22, 2019 at 12:10:23PM -0700, Sagi Grimberg wrote: > >> You are correct that this information can be derived from sysfs, but the > >> main reason why we add these here, is because in udev rule we can't > >> just go ahe

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-08-25 Thread Christoph Hellwig
On Thu, Aug 22, 2019 at 12:10:23PM -0700, Sagi Grimberg wrote: >> You are correct that this information can be derived from sysfs, but the >> main reason why we add these here, is because in udev rule we can't >> just go ahead and start looking these up and parsing these.. >> >> We could send the d