RE: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-12 Thread Mario.Limonciello
> > > > > > > > And what does mean "no function"? I do not know what should I imagine > if > > > I receive key press marked as "no function". > > > > It means no action is expected to occur, should behave like a no-op. I > think > > discarding it makes fine sense. > > Thank you! This was missing

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-12 Thread Pali Rohár
imonciello, Mario > > Cc: rdun...@infradead.org; y.li...@paritcher.com; linux- > > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; > > mj...@srcf.ucam.org > > Subject: Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to > > bios_to_linux_keycode > > &

RE: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-10 Thread Mario.Limonciello
.org; platform-driver-...@vger.kernel.org; > mj...@srcf.ucam.org > Subject: Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to > bios_to_linux_keycode > > > [EXTERNAL EMAIL] > > On Tuesday 09 June 2020 19:49:18 mario.limoncie...@dell.com wrote: > > > >

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-10 Thread Pali Rohár
On Tuesday 09 June 2020 19:49:18 mario.limoncie...@dell.com wrote: > > > > Looking at the last two lines... and for me it looks like that 0x00FF > > and 0x are just "placeholders" or special values for unknown / > > custom / unsupported / reserved / special / ... codes. > > > > It is really s

RE: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-09 Thread Mario.Limonciello
> > Looking at the last two lines... and for me it looks like that 0x00FF > and 0x are just "placeholders" or special values for unknown / > custom / unsupported / reserved / special / ... codes. > > It is really suspicious why first 38 values are defined, then there is > gap, then one value

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-09 Thread Pali Rohár
On Monday 08 June 2020 20:43:45 Y Paritcher wrote: > On 6/8/20 7:55 PM, Pali Rohár wrote: > > Hello! > > > > On Monday 08 June 2020 16:27:10 Randy Dunlap wrote: > >> Hi-- > >> > >> On 6/8/20 4:05 PM, Y Paritcher wrote: > >>> Increase length of bios_to_linux_keycode to 2 bytes (the true size of a >

[PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-08 Thread Y Paritcher
Increase length of bios_to_linux_keycode to 2 bytes (the true size of a keycode) to allow for a new keycode 0x, this silences the following messages being logged at startup on a Dell Inspiron 5593: dell_wmi: firmware scancode 0x48 maps to unrecognized keycode 0x dell_wmi: firmware

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-08 Thread Y Paritcher
On 6/8/20 7:55 PM, Pali Rohár wrote: > Hello! > > On Monday 08 June 2020 16:27:10 Randy Dunlap wrote: >> Hi-- >> >> On 6/8/20 4:05 PM, Y Paritcher wrote: >>> Increase length of bios_to_linux_keycode to 2 bytes (the true size of a >>> keycode) to allow for a new keycode 0x, this silences the fo

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-08 Thread Pali Rohár
Hello! On Monday 08 June 2020 16:27:10 Randy Dunlap wrote: > Hi-- > > On 6/8/20 4:05 PM, Y Paritcher wrote: > > Increase length of bios_to_linux_keycode to 2 bytes (the true size of a > > keycode) to allow for a new keycode 0x, this silences the following > > messages being logged at startup

Re: [PATCH v2 3/3] platform/x86: dell-wmi: add new dmi keys to bios_to_linux_keycode

2020-06-08 Thread Randy Dunlap
Hi-- On 6/8/20 4:05 PM, Y Paritcher wrote: > Increase length of bios_to_linux_keycode to 2 bytes (the true size of a > keycode) to allow for a new keycode 0x, this silences the following > messages being logged at startup on a Dell Inspiron 5593: > > dell_wmi: firmware scancode 0x48 maps