Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

2019-03-26 Thread Yafang Shao
On Tue, Mar 26, 2019 at 11:30 PM Steven Rostedt wrote: > > On Tue, 26 Mar 2019 08:18:15 -0700 > "Paul E. McKenney" wrote: > > > On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote: > > > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as > > > do-nothing macro. > > >

Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

2019-03-26 Thread Steven Rostedt
On Tue, 26 Mar 2019 08:18:15 -0700 "Paul E. McKenney" wrote: > On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote: > > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as > > do-nothing macro. > > We'd better make those inline functions that take proper arguments. > >

Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

2019-03-26 Thread Paul E. McKenney
On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote: > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as > do-nothing macro. > We'd better make those inline functions that take proper arguments. > > As RCU_TRACE() is defined as do-nothing marco as well when >

Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

2019-03-26 Thread Steven Rostedt
Paul, Are you OK with this patch? If you ack it, I'll pull it in through my tree. -- Steve On Tue, 26 Mar 2019 20:13:11 +0800 Yafang Shao wrote: > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as > do-nothing macro. > We'd better make those inline functions that take

[PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

2019-03-26 Thread Yafang Shao
When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as do-nothing macro. We'd better make those inline functions that take proper arguments. As RCU_TRACE() is defined as do-nothing marco as well when CONFIG_RCU_TRACE is not set, so we can clean it up. Signed-off-by: Yafang Shao