Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-29 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 01:07:06AM -0800, dbasehore . wrote: > That's an interesting question. Part of direct complete is to leave > the device runtime suspended even after the system resumes if > possible. The comments in pm_complete_with_resume_check indicate that > the firmware may resume a

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-29 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 01:07:06AM -0800, dbasehore . wrote: > That's an interesting question. Part of direct complete is to leave > the device runtime suspended even after the system resumes if > possible. The comments in pm_complete_with_resume_check indicate that > the firmware may resume a

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread dbasehore .
On Sat, Feb 27, 2016 at 12:38 AM, Mika Westerberg wrote: > On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote: >> A device is not able to use direct complete if its children do not >> also use direct complete. Even though the SCSI layer leaves devices >>

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread dbasehore .
On Sat, Feb 27, 2016 at 12:38 AM, Mika Westerberg wrote: > On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote: >> A device is not able to use direct complete if its children do not >> also use direct complete. Even though the SCSI layer leaves devices >> runtime suspended, the way it

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote: > A device is not able to use direct complete if its children do not > also use direct complete. Even though the SCSI layer leaves devices > runtime suspended, the way it does it still prevents its parent from > using direct complete.

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote: > A device is not able to use direct complete if its children do not > also use direct complete. Even though the SCSI layer leaves devices > runtime suspended, the way it does it still prevents its parent from > using direct complete.

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread dbasehore .
A device is not able to use direct complete if its children do not also use direct complete. Even though the SCSI layer leaves devices runtime suspended, the way it does it still prevents its parent from using direct complete. On Fri, Feb 26, 2016 at 11:26 PM, Mika Westerberg

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread dbasehore .
A device is not able to use direct complete if its children do not also use direct complete. Even though the SCSI layer leaves devices runtime suspended, the way it does it still prevents its parent from using direct complete. On Fri, Feb 26, 2016 at 11:26 PM, Mika Westerberg wrote: > On Wed,

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-26 Thread Mika Westerberg
On Wed, Feb 24, 2016 at 04:22:28PM -0800, Derek Basehore wrote: > This allows scsi devices to remain runtime suspended for system > suspend. Since runtime suspend is stricter than system suspend > callbacks, this is just returning a positive number for the prepare > callback. AFAICT SCSI layer

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-26 Thread Mika Westerberg
On Wed, Feb 24, 2016 at 04:22:28PM -0800, Derek Basehore wrote: > This allows scsi devices to remain runtime suspended for system > suspend. Since runtime suspend is stricter than system suspend > callbacks, this is just returning a positive number for the prepare > callback. AFAICT SCSI layer

[PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-24 Thread Derek Basehore
This allows scsi devices to remain runtime suspended for system suspend. Since runtime suspend is stricter than system suspend callbacks, this is just returning a positive number for the prepare callback. Signed-off-by: Derek Basehore Reviewed-by: Eric Caruso

[PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-24 Thread Derek Basehore
This allows scsi devices to remain runtime suspended for system suspend. Since runtime suspend is stricter than system suspend callbacks, this is just returning a positive number for the prepare callback. Signed-off-by: Derek Basehore Reviewed-by: Eric Caruso --- drivers/scsi/scsi_pm.c | 2 +-