Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-23 Thread Jan Glauber
On Fri, Aug 18, 2017 at 09:55:53PM -0600, Alex Williamson wrote: > On Fri, 18 Aug 2017 08:57:09 -0700 > David Daney wrote: > > > On 08/18/2017 07:12 AM, Alex Williamson wrote: [...] > > You previously rejected the idea to silently ignore bus reset requests > > on buses that do not support it.

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-18 Thread Alex Williamson
On Fri, 18 Aug 2017 08:57:09 -0700 David Daney wrote: > On 08/18/2017 07:12 AM, Alex Williamson wrote: > > On Fri, 18 Aug 2017 15:42:31 +0200 > > Jan Glauber wrote: > > > >> On Thu, Aug 17, 2017 at 07:00:17AM -0600, Alex Williamson wrote: > >>> On Thu, 17 Aug 2017 10:14:23 +0200 > >>> Jan G

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-18 Thread David Daney
On 08/18/2017 07:12 AM, Alex Williamson wrote: On Fri, 18 Aug 2017 15:42:31 +0200 Jan Glauber wrote: On Thu, Aug 17, 2017 at 07:00:17AM -0600, Alex Williamson wrote: On Thu, 17 Aug 2017 10:14:23 +0200 Jan Glauber wrote: If a PCI device supports neither function-level reset, nor slot or

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-18 Thread Alex Williamson
On Fri, 18 Aug 2017 15:42:31 +0200 Jan Glauber wrote: > On Thu, Aug 17, 2017 at 07:00:17AM -0600, Alex Williamson wrote: > > On Thu, 17 Aug 2017 10:14:23 +0200 > > Jan Glauber wrote: > > > > > If a PCI device supports neither function-level reset, nor slot > > > or bus reset then refuse to pr

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-18 Thread Jan Glauber
On Thu, Aug 17, 2017 at 07:00:17AM -0600, Alex Williamson wrote: > On Thu, 17 Aug 2017 10:14:23 +0200 > Jan Glauber wrote: > > > If a PCI device supports neither function-level reset, nor slot > > or bus reset then refuse to probe it. A line is printed to inform > > the user. > > But that's not

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-17 Thread Alex Williamson
On Thu, 17 Aug 2017 10:14:23 +0200 Jan Glauber wrote: > If a PCI device supports neither function-level reset, nor slot > or bus reset then refuse to probe it. A line is printed to inform > the user. But that's not what this does, this requires that the device is on a reset-able bus. This is a

[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-17 Thread Jan Glauber
If a PCI device supports neither function-level reset, nor slot or bus reset then refuse to probe it. A line is printed to inform the user. Without this change starting qemu with a vfio-pci device can lead to a kernel panic on some Cavium cn8xxx systems, depending on the used device. Signed-off-b