Re: [PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173

2015-07-02 Thread Daniel Kurtz
On Fri, Jul 3, 2015 at 1:15 PM, James Liao wrote: > On Wed, 2015-07-01 at 22:54 +0800, Daniel Kurtz wrote: >> On Tue, Jun 30, 2015 at 10:58 AM, James Liao >> wrote: >> > >> > +static struct mtk_gate_regs cg_regs_4_8_0 = { >> >> These should all be: >> >> static const struct mtk_gate_regs ... > >

Re: [PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173

2015-07-02 Thread James Liao
On Wed, 2015-07-01 at 22:54 +0800, Daniel Kurtz wrote: > On Tue, Jun 30, 2015 at 10:58 AM, James Liao > wrote: > > > > +static struct mtk_gate_regs cg_regs_4_8_0 = { > > These should all be: > > static const struct mtk_gate_regs ... OK, I'll fix it. > > + .set_ofs = 0x0004, > > +

Re: [PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173

2015-07-01 Thread Daniel Kurtz
On Tue, Jun 30, 2015 at 10:58 AM, James Liao wrote: > Most multimedia subsystem clocks will be accessed by multiple > drivers, so it's a better way to manage these clocks in CCF. > This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT > subsystems. > > Signed-off-by: James Liao > ---

[PATCH v2 3/4] clk: mediatek: Add subsystem clocks of MT8173

2015-06-29 Thread James Liao
Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 298