Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-24 Thread Milo Kim
Hi Andrzej, On 08/24/2016 02:55 PM, Andrzej Hajda wrote: This is mistake introduced by other patch, of_node_put should be called on np, after calling of_find_i2c_adapter_by_node. You can fix it in your patch as well. I think you can move of_find_i2c_adapter_by_node also to this function and

Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-24 Thread Milo Kim
Hi Andrzej, On 08/24/2016 02:55 PM, Andrzej Hajda wrote: This is mistake introduced by other patch, of_node_put should be called on np, after calling of_find_i2c_adapter_by_node. You can fix it in your patch as well. I think you can move of_find_i2c_adapter_by_node also to this function and

Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-23 Thread Andrzej Hajda
On 08/24/2016 04:25 AM, Milo Kim wrote: > Handle legacy and raw 'ddc' parsing in single function. > And it also removes goto condition. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: David Airlie > Cc: Inki Dae

Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-23 Thread Andrzej Hajda
On 08/24/2016 04:25 AM, Milo Kim wrote: > Handle legacy and raw 'ddc' parsing in single function. > And it also removes goto condition. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: David Airlie > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Rob

[PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-23 Thread Milo Kim
Handle legacy and raw 'ddc' parsing in single function. And it also removes goto condition. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: David Airlie Cc: Inki Dae Cc: Joonyoung Shim Cc:

[PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-23 Thread Milo Kim
Handle legacy and raw 'ddc' parsing in single function. And it also removes goto condition. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: David Airlie Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Rob Herring Cc: devicet...@vger.kernel.org Cc: