Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-04-08 Thread Quan Nguyen
On 07/04/2021 19:11, Guenter Roeck wrote: On 4/7/21 12:41 AM, Quan Nguyen wrote: [ ... ] But then why don't you just use reg_ext to store SOC_VR_HOT_THRESHOLD_REG or MEM_HOT_THRESHOLD_REG ? It is already available, after all, and with it the code could be simplified to     ret = regmap_re

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-04-07 Thread Guenter Roeck
On 4/7/21 12:41 AM, Quan Nguyen wrote: [ ... ] >> >> But then why don't you just use reg_ext to store SOC_VR_HOT_THRESHOLD_REG >> or MEM_HOT_THRESHOLD_REG ? It is already available, after all, and with it >> the code could be simplified to >> >>     ret = regmap_read(hwmon->regmap, temperature[

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-04-07 Thread Quan Nguyen
On 30/03/2021 08:43, Guenter Roeck wrote: On 3/28/21 6:52 PM, Quan Nguyen wrote: This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-03-29 Thread Guenter Roeck
On 3/28/21 6:52 PM, Quan Nguyen wrote: > This commit adds support for Ampere SMpro hwmon driver. This driver > supports accessing various CPU sensors provided by the SMpro co-processor > including temperature, power, voltages, and current. > > Signed-off-by: Quan Nguyen > --- > drivers/hwmon/Kco

[PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-03-28 Thread Quan Nguyen
This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan Nguyen --- drivers/hwmon/Kconfig | 8 + drivers/hwmon/Makefile | 1