Re: [PATCH v2 3/4] mm: introduce page memcg flags

2020-09-24 Thread Shakeel Butt
On Thu, Sep 24, 2020 at 12:29 PM Roman Gushchin wrote: > > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg flags, def

[PATCH v2 3/4] mm: introduce page memcg flags

2020-09-24 Thread Roman Gushchin
The lowest bit in page->memcg_data is used to distinguish between struct memory_cgroup pointer and a pointer to a objcgs array. All checks and modifications of this bit are open-coded. Let's formalize it using page memcg flags, defined in page_memcg_flags enum, and replace all open-coded accesses