Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-27 Thread Lukasz Majewski
Hi Eduardo, > > Hello Navneet, > > On Wed, Nov 26, 2014 at 12:43:18PM -0800, navneet kumar wrote: > > > > Hi Eduardo, Lukasz, > > > > [Combining my concerns as a single text blob here] > > > > I. Firstly, with the current patch > > 1. is it really needed to duplicate the struct > > therma

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread Eduardo Valentin
Hello Navneet, On Wed, Nov 26, 2014 at 12:43:18PM -0800, navneet kumar wrote: > > Hi Eduardo, Lukasz, > > [Combining my concerns as a single text blob here] > > I. Firstly, with the current patch > 1. is it really needed to duplicate the struct thermal_trip? Why don’t > we get rid

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread navneet kumar
On 11/26/2014 01:12 PM, Guenter Roeck wrote: > On 11/26/2014 12:43 PM, navneet kumar wrote: >> >> Hi Eduardo, Lukasz, >> >> [Combining my concerns as a single text blob here] >> >> I. Firstly, with the current patch >> 1. is it really needed to duplicate the struct thermal_trip? Why >> don’t

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread Guenter Roeck
On 11/26/2014 12:43 PM, navneet kumar wrote: Hi Eduardo, Lukasz, [Combining my concerns as a single text blob here] I. Firstly, with the current patch 1. is it really needed to duplicate the struct thermal_trip? Why don’t we get rid of the __thermal_trip and stay with the 'ther

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread navneet kumar
Hi Eduardo, Lukasz, [Combining my concerns as a single text blob here] I. Firstly, with the current patch 1. is it really needed to duplicate the struct thermal_trip? Why don’t we get rid of the __thermal_trip and stay with the 'thermal_trip' ? it is not a big change.

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread Eduardo Valentin
Hello, On Wed, Nov 26, 2014 at 09:35:10AM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > Hello Lukasz, > > > > On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > > > This patch extends the of-thermal.c to export copy of trip points > > > for a given thermal zone. > > > > > >

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread Lukasz Majewski
Hi Eduardo, > On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > > This patch extends the of-thermal.c to export copy of trip points > > for a given thermal zone. > > > > Thermal drivers should use of_thermal_get_trip_points() method to > > get pointer to table of thermal trip poi

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread Lukasz Majewski
Hi Eduardo, > Hello Lukasz, > > On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > > This patch extends the of-thermal.c to export copy of trip points > > for a given thermal zone. > > > > Thermal drivers should use of_thermal_get_trip_points() method to > > get pointer to table

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-25 Thread Eduardo Valentin
On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > This patch extends the of-thermal.c to export copy of trip points for > a given thermal zone. > > Thermal drivers should use of_thermal_get_trip_points() method to get > pointer to table of thermal trip points. > > Signed-off-by:

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-25 Thread Eduardo Valentin
Hello Lukasz, On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > This patch extends the of-thermal.c to export copy of trip points for > a given thermal zone. > > Thermal drivers should use of_thermal_get_trip_points() method to get > pointer to table of thermal trip points. > >

[PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-20 Thread Lukasz Majewski
This patch extends the of-thermal.c to export copy of trip points for a given thermal zone. Thermal drivers should use of_thermal_get_trip_points() method to get pointer to table of thermal trip points. Signed-off-by: Lukasz Majewski --- Changes for v2: - New patch - as suggested by Eduardo Vale