Re: [PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-30 Thread Arnd Bergmann
On Monday 27 April 2015 14:55:41 Brian Norris wrote: > On Fri, Apr 24, 2015 at 09:46:01AM +0200, Arnd Bergmann wrote: > > On Thursday 23 April 2015 09:46:11 Brian Norris wrote: > > > On Thu, Apr 23, 2015 at 09:43:55AM +0200, Arnd Bergmann wrote: > > > > On Wednesday 22 April 2015 19:59:08 Brian Nor

Re: [PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-27 Thread Brian Norris
On Fri, Apr 24, 2015 at 09:46:01AM +0200, Arnd Bergmann wrote: > On Thursday 23 April 2015 09:46:11 Brian Norris wrote: > > On Thu, Apr 23, 2015 at 09:43:55AM +0200, Arnd Bergmann wrote: > > > On Wednesday 22 April 2015 19:59:08 Brian Norris wrote: [snip] > > So we have a PHY driver, but it doesn'

Re: [PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-24 Thread Arnd Bergmann
On Thursday 23 April 2015 09:46:11 Brian Norris wrote: > Hi Arnd, > > On Thu, Apr 23, 2015 at 09:43:55AM +0200, Arnd Bergmann wrote: > > On Wednesday 22 April 2015 19:59:08 Brian Norris wrote: > > > Pretty straightforward driver, using the nice library-ization of the > > > generic ahci_platform dr

Re: [PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-23 Thread Brian Norris
Hi Arnd, On Thu, Apr 23, 2015 at 09:43:55AM +0200, Arnd Bergmann wrote: > On Wednesday 22 April 2015 19:59:08 Brian Norris wrote: > > Pretty straightforward driver, using the nice library-ization of the > > generic ahci_platform driver. > > > > Signed-off-by: Brian Norris > > There is an altern

Re: [PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-23 Thread Arnd Bergmann
On Wednesday 22 April 2015 19:59:08 Brian Norris wrote: > Pretty straightforward driver, using the nice library-ization of the > generic ahci_platform driver. > > Signed-off-by: Brian Norris There is an alternative way to do this, by writing a separate phy driver for drivers/phy and using the ge

[PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-22 Thread Brian Norris
Pretty straightforward driver, using the nice library-ization of the generic ahci_platform driver. Signed-off-by: Brian Norris --- v2: - move port enabling into this driver, since the affected registers are in the SATA_TOP_CTRL block. This means we need to check for the implemented port