Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-26 Thread Matthias Kaehlcke
On Fri, Mar 22, 2019 at 08:45:26AM -0400, Gaël PORTAY wrote: > Hi Matthias, > > On Thu, Mar 21, 2019 at 05:01:07PM -0700, Matthias Kaehlcke wrote: > > > ... > > > > > > So, for a reason that I ignore, if we try to save unecessary calls to > > > ROCKCHIP_SIP_CONFIG_DRAM_SET_ODT_PD (odt_enable has

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-22 Thread Gaël PORTAY
Hi Matthias, On Thu, Mar 21, 2019 at 05:01:07PM -0700, Matthias Kaehlcke wrote: > > ... > > > > So, for a reason that I ignore, if we try to save unecessary calls to > > ROCKCHIP_SIP_CONFIG_DRAM_SET_ODT_PD (odt_enable has not changed since > > last call), we get stalled in the call to ROCKCHIP_SI

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-21 Thread Matthias Kaehlcke
Hi Gaël, On Thu, Mar 21, 2019 at 07:10:55PM -0400, Gaël PORTAY wrote: > Matthias, > > On Wed, Mar 20, 2019 at 03:02:23PM -0700, Matthias Kaehlcke wrote: > > Hi Gaël, > > > > On Wed, Mar 20, 2019 at 05:50:13PM -0400, Gaël PORTAY wrote: > > > Hi Matthias, > > > > > > On Tue, Mar 19, 2019 at 05:33

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-21 Thread Gaël PORTAY
Matthias, On Wed, Mar 20, 2019 at 03:02:23PM -0700, Matthias Kaehlcke wrote: > Hi Gaël, > > On Wed, Mar 20, 2019 at 05:50:13PM -0400, Gaël PORTAY wrote: > > Hi Matthias, > > > > On Tue, Mar 19, 2019 at 05:33:52PM -0700, Matthias Kaehlcke wrote: > > > ... > > > > @@ -95,6 +103,19 @@ static int rk

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-20 Thread Matthias Kaehlcke
Hi Gaël, On Wed, Mar 20, 2019 at 05:50:13PM -0400, Gaël PORTAY wrote: > Hi Matthias, > > On Tue, Mar 19, 2019 at 05:33:52PM -0700, Matthias Kaehlcke wrote: > > ... > > > @@ -95,6 +103,19 @@ static int rk3399_dmcfreq_target(struct device *dev, > > > unsigned long *freq, > > > > > > mutex_lock

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-20 Thread Gaël PORTAY
Hi Matthias, On Tue, Mar 19, 2019 at 05:33:52PM -0700, Matthias Kaehlcke wrote: > ... > > @@ -95,6 +103,19 @@ static int rk3399_dmcfreq_target(struct device *dev, > > unsigned long *freq, > > > > mutex_lock(&dmcfreq->lock); > > > > + if (target_rate >= dmcfreq->odt_dis_freq) > > +

Re: [PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-19 Thread Matthias Kaehlcke
Hi Gaël, On Tue, Mar 19, 2019 at 02:13:21PM -0400, Gaël PORTAY wrote: > From: Enric Balletbo i Serra > > Trusted Firmware-A (TF-A) for rk3399 implements a SiP call to get the > on-die termination (ODT) and auto power down parameters from kernel, > this patch adds the functionality to do this. Al

[PATCH v2 3/5] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-03-19 Thread Gaël PORTAY
From: Enric Balletbo i Serra Trusted Firmware-A (TF-A) for rk3399 implements a SiP call to get the on-die termination (ODT) and auto power down parameters from kernel, this patch adds the functionality to do this. Also, if DDR clock frequency is lower than the on-die termination (ODT) disable fre