Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver

2017-06-29 Thread Uwe Kleine-König
Hello, On Thu, Jun 29, 2017 at 02:40:44PM +, Pierre Yves MORDRET wrote: > >> + /* Arbitration loss */ > >> + if (status & STM32F7_I2C_ISR_ARLO) { > >> + dev_err(dev, "<%s>: Arbitration loss\n", __func__); > > > > Drop this. Arbitration loss is not an error and it shouldn't pollute

Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver

2017-06-29 Thread Pierre Yves MORDRET
Hello On 06/27/2017 10:51 PM, Uwe Kleine-König wrote: > Hello, > > just a quick review as last act in the night. I don't claim to catch > everything at this time of the day. So don't be surprised if I still > find something to criticize after you fixed everything. But keeping this > until I find

Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver

2017-06-27 Thread Uwe Kleine-König
Hello, just a quick review as last act in the night. I don't claim to catch everything at this time of the day. So don't be surprised if I still find something to criticize after you fixed everything. But keeping this until I find time to look again seems wrong to me. On Tue, Jun 20, 2017 at 01:4

[PATCH v2 3/5] i2c: i2c-stm32f7: add driver

2017-06-20 Thread Pierre-Yves MORDRET
This patch adds initial support for the STM32F7 I2C controller. Signed-off-by: M'boumba Cedric Madianga Signed-off-by: Pierre-Yves MORDRET --- Changes in V2: * Remove st,i2c-timing binding usage * Implement an I2C timings computation algorithm instead of static values(bindings). Algorith