Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-23 Thread Oscar Salvador
On Mon, Jul 23, 2018 at 10:35:19AM +0200, Michal Hocko wrote: > No, I do not think this is much better. Why do we need to separate those > functions out? I think you are too focused on the current function > without a broader context. Think about it. We have two code paths. > Early initialization a

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-23 Thread Michal Hocko
On Fri 20-07-18 12:03:27, Oscar Salvador wrote: > On Thu, Jul 19, 2018 at 10:52:35PM +0200, Oscar Salvador wrote: > > On Thu, Jul 19, 2018 at 05:15:55PM +0200, Michal Hocko wrote: > > > Your changelog doesn't really explain the motivation. Does the change > > > help performance? Is this a pure clea

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-23 Thread Michal Hocko
On Thu 19-07-18 22:52:35, Oscar Salvador wrote: > On Thu, Jul 19, 2018 at 05:15:55PM +0200, Michal Hocko wrote: > > Your changelog doesn't really explain the motivation. Does the change > > help performance? Is this a pure cleanup? > > Hi Michal, > > Sorry to not have explained this better from t

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-20 Thread Oscar Salvador
On Thu, Jul 19, 2018 at 10:52:35PM +0200, Oscar Salvador wrote: > On Thu, Jul 19, 2018 at 05:15:55PM +0200, Michal Hocko wrote: > > Your changelog doesn't really explain the motivation. Does the change > > help performance? Is this a pure cleanup? > > Hi Michal, > > Sorry to not have explained th

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-19 Thread Oscar Salvador
On Thu, Jul 19, 2018 at 05:15:55PM +0200, Michal Hocko wrote: > Your changelog doesn't really explain the motivation. Does the change > help performance? Is this a pure cleanup? Hi Michal, Sorry to not have explained this better from the very beginning. It should help a bit in performance terms

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-19 Thread Michal Hocko
On Thu 19-07-18 16:03:27, Oscar Salvador wrote: > On Thu, Jul 19, 2018 at 03:44:17PM +0200, Michal Hocko wrote: > > On Thu 19-07-18 15:27:38, osalva...@techadventures.net wrote: > > > From: Oscar Salvador > > > > > > In free_area_init_core we calculate the amount of managed pages > > > we are lef

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-19 Thread Oscar Salvador
On Thu, Jul 19, 2018 at 03:44:17PM +0200, Michal Hocko wrote: > On Thu 19-07-18 15:27:38, osalva...@techadventures.net wrote: > > From: Oscar Salvador > > > > In free_area_init_core we calculate the amount of managed pages > > we are left with, by substracting the memmap pages and the pages > > r

Re: [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-19 Thread Michal Hocko
On Thu 19-07-18 15:27:38, osalva...@techadventures.net wrote: > From: Oscar Salvador > > In free_area_init_core we calculate the amount of managed pages > we are left with, by substracting the memmap pages and the pages > reserved for dma. > With the values left, we also account the total of kern

[PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core

2018-07-19 Thread osalvador
From: Oscar Salvador In free_area_init_core we calculate the amount of managed pages we are left with, by substracting the memmap pages and the pages reserved for dma. With the values left, we also account the total of kernel pages and the total of pages. Since memmap pages are calculated from z