Re: [PATCH v2 3/5] pstore/ram: in ramoops_platform_data convert dump_oops to max_reason

2020-05-06 Thread Pavel Tatashin
> > Remove filtering logic from ramoops_pstore_write(), as that is not needed > > anymore, only dmesges specified by max_reason are passed to > > ramoops_pstore_write(). Also, because of this, we can remove > > cxt->dump_oops. > > This is all looking good. I think I'd like to see patch 3 and 4

Re: [PATCH v2 3/5] pstore/ram: in ramoops_platform_data convert dump_oops to max_reason

2020-05-05 Thread Kees Cook
On Tue, May 05, 2020 at 11:45:08AM -0400, Pavel Tatashin wrote: > Now, that pstore_register() can correctly pass max_reason to kmesg dump > facility, use it instead of dump_oops boolean. > > Replace in ramoops_platform_data dump_oops with max_reason. When dump_oops > was enabled set max_reason to

[PATCH v2 3/5] pstore/ram: in ramoops_platform_data convert dump_oops to max_reason

2020-05-05 Thread Pavel Tatashin
Now, that pstore_register() can correctly pass max_reason to kmesg dump facility, use it instead of dump_oops boolean. Replace in ramoops_platform_data dump_oops with max_reason. When dump_oops was enabled set max_reason to KMSG_DUMP_OOPS, otherwise set it to KMSG_DUMP_PANIC. Remove filtering