Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Darren Hart
On Mon, Sep 15, 2014 at 02:01:23PM -0700, H. Peter Anvin wrote: > On 09/15/2014 12:56 PM, Greg Kroah-Hartman wrote: > > > >> I have also suggested this device (2 actually) would be better supported > >> as an > >> IIO accelerometer device, but even that would change the sysfs interface by > >>

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread H. Peter Anvin
On 09/15/2014 12:56 PM, Greg Kroah-Hartman wrote: > >> I have also suggested this device (2 actually) would be better supported as >> an >> IIO accelerometer device, but even that would change the sysfs interface by >> removing these altogether and using the IIO standardized path and >>

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 12:29:27PM -0700, Darren Hart wrote: > On Fri, Sep 12, 2014 at 06:50:37PM -0600, Azael Avalos wrote: > > The position file on sysfs was reporting absolute values > > for its axes. > > > > This patch fixes the direction reporting (either negative > > or positive), as well

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Darren Hart
On Fri, Sep 12, 2014 at 06:50:37PM -0600, Azael Avalos wrote: > The position file on sysfs was reporting absolute values > for its axes. > > This patch fixes the direction reporting (either negative > or positive), as well as added a mutex lock to it. > Hi All, I've added Greg KH, Rafael, and

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Darren Hart
On Fri, Sep 12, 2014 at 06:50:37PM -0600, Azael Avalos wrote: The position file on sysfs was reporting absolute values for its axes. This patch fixes the direction reporting (either negative or positive), as well as added a mutex lock to it. Hi All, I've added Greg KH, Rafael, and H.

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 12:29:27PM -0700, Darren Hart wrote: On Fri, Sep 12, 2014 at 06:50:37PM -0600, Azael Avalos wrote: The position file on sysfs was reporting absolute values for its axes. This patch fixes the direction reporting (either negative or positive), as well as added a

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread H. Peter Anvin
On 09/15/2014 12:56 PM, Greg Kroah-Hartman wrote: I have also suggested this device (2 actually) would be better supported as an IIO accelerometer device, but even that would change the sysfs interface by removing these altogether and using the IIO standardized path and accelerometer

Re: [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-15 Thread Darren Hart
On Mon, Sep 15, 2014 at 02:01:23PM -0700, H. Peter Anvin wrote: On 09/15/2014 12:56 PM, Greg Kroah-Hartman wrote: I have also suggested this device (2 actually) would be better supported as an IIO accelerometer device, but even that would change the sysfs interface by removing these

[PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-12 Thread Azael Avalos
The position file on sysfs was reporting absolute values for its axes. This patch fixes the direction reporting (either negative or positive), as well as added a mutex lock to it. Signed-off-by: Azael Avalos --- This was: Add accelerometer input polled device Changes since v1: Dropped polldev

[PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting

2014-09-12 Thread Azael Avalos
The position file on sysfs was reporting absolute values for its axes. This patch fixes the direction reporting (either negative or positive), as well as added a mutex lock to it. Signed-off-by: Azael Avalos coproscef...@gmail.com --- This was: Add accelerometer input polled device Changes