Re: [PATCH v2 3/6] netlink/compat: Append NLMSG_DONE/extack to frag_list

2020-09-07 Thread Dmitry Safonov
On 8/26/20 8:19 AM, Johannes Berg wrote: > On Wed, 2020-08-26 at 02:49 +0100, Dmitry Safonov wrote: [..] >> +nl_dump_check_consistent(cb, nlh); >> +memcpy(nlmsg_data(nlh), &nlk->dump_done_errno, >> +sizeof(nlk->dump_done_errno)); > > nit: indentation here looks odd. >

Re: [PATCH v2 3/6] netlink/compat: Append NLMSG_DONE/extack to frag_list

2020-08-26 Thread Johannes Berg
On Wed, 2020-08-26 at 02:49 +0100, Dmitry Safonov wrote: > Modules those use netlink may supply a 2nd skb, (via frag_list) > that contains an alternative data set meant for applications > using 32bit compatibility mode. Do note, however, that until this day the facility here was only used by (and

[PATCH v2 3/6] netlink/compat: Append NLMSG_DONE/extack to frag_list

2020-08-25 Thread Dmitry Safonov
Modules those use netlink may supply a 2nd skb, (via frag_list) that contains an alternative data set meant for applications using 32bit compatibility mode. In such a case, netlink_recvmsg will use this 2nd skb instead of the original one. Without this patch, such compat applications will retriev