Re: [PATCH v2 3/6] spi: sun4i: coding style/readability improvements

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:29:02PM +0300, Sergey Suloev wrote: > Minor changes to fulfill the coding style and > improve the readability. Again, this is a very subjective statement. Overall, I'm not convinced by the idea of moving code around and shuffling variables assignments just for the sake

Re: [PATCH v2 3/6] spi: sun4i: coding style/readability improvements

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:29:02PM +0300, Sergey Suloev wrote: > Minor changes to fulfill the coding style and > improve the readability. Again, this is a very subjective statement. Overall, I'm not convinced by the idea of moving code around and shuffling variables assignments just for the sake

[PATCH v2 3/6] spi: sun4i: coding style/readability improvements

2018-04-03 Thread Sergey Suloev
Minor changes to fulfill the coding style and improve the readability. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun4i.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/spi/spi-sun4i.c

[PATCH v2 3/6] spi: sun4i: coding style/readability improvements

2018-04-03 Thread Sergey Suloev
Minor changes to fulfill the coding style and improve the readability. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun4i.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index