Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
On 10/22/2015 02:09 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 13:54:42 Eric Auger wrote: >> On 10/22/2015 12:13 PM, Arnd Bergmann wrote: >>> On Thursday 22 October 2015 11:41:59 Eric Auger wrote: This patch adds the reset function registration/unregistration.

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 13:54:42 Eric Auger wrote: > On 10/22/2015 12:13 PM, Arnd Bergmann wrote: > > On Thursday 22 October 2015 11:41:59 Eric Auger wrote: > >> This patch adds the reset function registration/unregistration. > >> > >> Signed-off-by: Eric Auger > > > > Looks good, except one

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
On 10/22/2015 12:13 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 11:41:59 Eric Auger wrote: >> This patch adds the reset function registration/unregistration. >> >> Signed-off-by: Eric Auger > > Looks good, except one thing: >> @@ -70,6 +69,8 @@ int

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 11:41:59 Eric Auger wrote: > This patch adds the reset function registration/unregistration. > > Signed-off-by: Eric Auger Looks good, except one thing: > @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct > vfio_platform_device *vdev) >

[PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
This patch adds the reset function registration/unregistration. Signed-off-by: Eric Auger --- v1 -> v2: - uses the module_vfio_reset_handler macro - add pr_info on vfio reset - do not export vfio_platform_calxedaxgmac_reset symbol anymore ---

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
On 10/22/2015 12:13 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 11:41:59 Eric Auger wrote: >> This patch adds the reset function registration/unregistration. >> >> Signed-off-by: Eric Auger > > Looks good, except one thing: >> @@ -70,6 +69,8 @@ int

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 13:54:42 Eric Auger wrote: > On 10/22/2015 12:13 PM, Arnd Bergmann wrote: > > On Thursday 22 October 2015 11:41:59 Eric Auger wrote: > >> This patch adds the reset function registration/unregistration. > >> > >> Signed-off-by: Eric Auger > > > >

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 11:41:59 Eric Auger wrote: > This patch adds the reset function registration/unregistration. > > Signed-off-by: Eric Auger Looks good, except one thing: > @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct > vfio_platform_device

[PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
This patch adds the reset function registration/unregistration. Signed-off-by: Eric Auger --- v1 -> v2: - uses the module_vfio_reset_handler macro - add pr_info on vfio reset - do not export vfio_platform_calxedaxgmac_reset symbol anymore ---

Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

2015-10-22 Thread Eric Auger
On 10/22/2015 02:09 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 13:54:42 Eric Auger wrote: >> On 10/22/2015 12:13 PM, Arnd Bergmann wrote: >>> On Thursday 22 October 2015 11:41:59 Eric Auger wrote: This patch adds the reset function registration/unregistration.