Re: [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-09 Thread Lucas De Marchi
On Sat, Mar 9, 2013 at 5:23 PM, Oleg Nesterov wrote: > On 03/08, Lucas De Marchi wrote: >> >> Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of >> calling call_usermodehelper_fns(). In case the latter returns -ENOMEM >> the cleanup function may had not been called - in this

Re: [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-09 Thread Oleg Nesterov
On 03/08, Lucas De Marchi wrote: > > Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of > calling call_usermodehelper_fns(). In case the latter returns -ENOMEM > the cleanup function may had not been called - in this case we would > not free argv and module_name. > >

Re: [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-09 Thread Oleg Nesterov
On 03/08, Lucas De Marchi wrote: Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of calling call_usermodehelper_fns(). In case the latter returns -ENOMEM the cleanup function may had not been called - in this case we would not free argv and module_name. Signed-off-by:

Re: [PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-09 Thread Lucas De Marchi
On Sat, Mar 9, 2013 at 5:23 PM, Oleg Nesterov o...@redhat.com wrote: On 03/08, Lucas De Marchi wrote: Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of calling call_usermodehelper_fns(). In case the latter returns -ENOMEM the cleanup function may had not been called - in

[PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-07 Thread Lucas De Marchi
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of calling call_usermodehelper_fns(). In case the latter returns -ENOMEM the cleanup function may had not been called - in this case we would not free argv and module_name. Signed-off-by: Lucas De Marchi --- kernel/kmod.c | 15

[PATCH v2 3/7] kmod: split call to call_usermodehelper_fns()

2013-03-07 Thread Lucas De Marchi
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of calling call_usermodehelper_fns(). In case the latter returns -ENOMEM the cleanup function may had not been called - in this case we would not free argv and module_name. Signed-off-by: Lucas De Marchi