Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-06 Thread Vladimir Davydov
On 02/06/2014 10:17 PM, Michal Hocko wrote: > On Thu 06-02-14 21:12:51, Vladimir Davydov wrote: >> On 02/06/2014 08:41 PM, Michal Hocko wrote: > [...] +int kmem_cache_create_memcg(struct mem_cgroup *memcg, struct kmem_cache *cachep) { - return kmem_cache_create_memcg(NULL, na

Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-06 Thread Michal Hocko
On Thu 06-02-14 21:12:51, Vladimir Davydov wrote: > On 02/06/2014 08:41 PM, Michal Hocko wrote: [...] > >> +int kmem_cache_create_memcg(struct mem_cgroup *memcg, struct kmem_cache > >> *cachep) > >> { > >> - return kmem_cache_create_memcg(NULL, name, size, align, flags, ctor, > >> NULL); > >> +

Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-06 Thread Vladimir Davydov
On 02/06/2014 08:41 PM, Michal Hocko wrote: > On Tue 04-02-14 23:19:24, Vladimir Davydov wrote: >> On 02/04/2014 08:03 PM, Michal Hocko wrote: >>> On Mon 03-02-14 19:54:38, Vladimir Davydov wrote: Memcg-awareness turned kmem_cache_create() into a dirty interweaving of memcg-only and excep

Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-06 Thread Michal Hocko
On Tue 04-02-14 23:19:24, Vladimir Davydov wrote: > On 02/04/2014 08:03 PM, Michal Hocko wrote: > > On Mon 03-02-14 19:54:38, Vladimir Davydov wrote: > >> Memcg-awareness turned kmem_cache_create() into a dirty interweaving of > >> memcg-only and except-for-memcg calls. To clean this up, let's crea

Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-04 Thread Vladimir Davydov
On 02/04/2014 08:03 PM, Michal Hocko wrote: > On Mon 03-02-14 19:54:38, Vladimir Davydov wrote: >> Memcg-awareness turned kmem_cache_create() into a dirty interweaving of >> memcg-only and except-for-memcg calls. To clean this up, let's create a >> separate function handling memcg caches creation.

Re: [PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-04 Thread Michal Hocko
On Mon 03-02-14 19:54:38, Vladimir Davydov wrote: > Memcg-awareness turned kmem_cache_create() into a dirty interweaving of > memcg-only and except-for-memcg calls. To clean this up, let's create a > separate function handling memcg caches creation. Although this will > result in the two functions

[PATCH v2 3/7] memcg, slab: separate memcg vs root cache creation paths

2014-02-03 Thread Vladimir Davydov
Memcg-awareness turned kmem_cache_create() into a dirty interweaving of memcg-only and except-for-memcg calls. To clean this up, let's create a separate function handling memcg caches creation. Although this will result in the two functions having several hunks of practically the same code, I guess