Re: [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-21 Thread Punit Agrawal
TSUKADA Koutaro writes: > On 2018/05/19 2:51, Punit Agrawal wrote: >> Punit Agrawal writes: >> >>> Tsukada-san, >>> >>> I am not familiar with memcg so can't comment about whether the patchset >>> is the right way to solve the problem outlined in the cover letter but >>> had a couple of comments

Re: [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-20 Thread TSUKADA Koutaro
On 2018/05/19 2:51, Punit Agrawal wrote: Punit Agrawal writes: Tsukada-san, I am not familiar with memcg so can't comment about whether the patchset is the right way to solve the problem outlined in the cover letter but had a couple of comments about this patch. TSUKADA Koutaro writes: Th

Re: [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-18 Thread Punit Agrawal
Punit Agrawal writes: > Tsukada-san, > > I am not familiar with memcg so can't comment about whether the patchset > is the right way to solve the problem outlined in the cover letter but > had a couple of comments about this patch. > > TSUKADA Koutaro writes: > >> The current memcg implementatio

Re: [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-18 Thread Punit Agrawal
Tsukada-san, I am not familiar with memcg so can't comment about whether the patchset is the right way to solve the problem outlined in the cover letter but had a couple of comments about this patch. TSUKADA Koutaro writes: > The current memcg implementation assumes that the compound page is TH

[PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-17 Thread TSUKADA Koutaro
The current memcg implementation assumes that the compound page is THP. In order to be able to charge surplus hugepage, we use compound_order. Signed-off-by: TSUKADA Koutaro --- memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/mem