Re: [PATCH v2 3/7] scsi: libsas: optimize the debug print of the revalidate process

2019-01-31 Thread John Garry
On 31/01/2019 01:31, Jason Yan wrote: On 2019/1/31 0:41, John Garry wrote: On 30/01/2019 08:24, Jason Yan wrote: sas_rediscover() returns error code if discover failed for a expander phy. And sas_ex_revalidate_domain() only returns the last phy's error code. So when sas_revalidate_domain()

Re: [PATCH v2 3/7] scsi: libsas: optimize the debug print of the revalidate process

2019-01-30 Thread Jason Yan
On 2019/1/31 0:41, John Garry wrote: On 30/01/2019 08:24, Jason Yan wrote: sas_rediscover() returns error code if discover failed for a expander phy. And sas_ex_revalidate_domain() only returns the last phy's error code. So when sas_revalidate_domain() prints the return value of the discover

Re: [PATCH v2 3/7] scsi: libsas: optimize the debug print of the revalidate process

2019-01-30 Thread John Garry
On 30/01/2019 08:24, Jason Yan wrote: sas_rediscover() returns error code if discover failed for a expander phy. And sas_ex_revalidate_domain() only returns the last phy's error code. So when sas_revalidate_domain() prints the return value of the discover process, we do not know if the

[PATCH v2 3/7] scsi: libsas: optimize the debug print of the revalidate process

2019-01-30 Thread Jason Yan
sas_rediscover() returns error code if discover failed for a expander phy. And sas_ex_revalidate_domain() only returns the last phy's error code. So when sas_revalidate_domain() prints the return value of the discover process, we do not know if the revalidation for every phy is successful or not.