Re: [PATCH v2 3/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

2020-06-29 Thread Dennis Dalessandro
On 6/15/2020 3:32 AM, refactormys...@gmail.com wrote: From: Bolarinwa Olayemi Saheed restore_pci_variables() and save_pci_variables() return PCIBIOS_ error codes from PCIe capability accessors. PCIBIOS_ error codes have positive values. Passing on these values is inconsistent with functions wh

[PATCH v2 3/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

2020-06-15 Thread refactormyself
From: Bolarinwa Olayemi Saheed restore_pci_variables() and save_pci_variables() return PCIBIOS_ error codes from PCIe capability accessors. PCIBIOS_ error codes have positive values. Passing on these values is inconsistent with functions which return only a negative value on failure. Before pas