Re: [PATCH v2 3/8] document rwsem_release() in sb_wait_write()

On Tue 11-08-15 19:04:04, Oleg Nesterov wrote: > Not only we need to avoid the warning from lockdep_sys_exit(), the > caller of freeze_super() can never release this lock. Another thread > can do this, so there is another reason for rwsem_release(). > > Plus the comment should explain why we have

Re: [PATCH v2 3/8] document rwsem_release() in sb_wait_write()

On Tue 11-08-15 19:04:04, Oleg Nesterov wrote: Not only we need to avoid the warning from lockdep_sys_exit(), the caller of freeze_super() can never release this lock. Another thread can do this, so there is another reason for rwsem_release(). Plus the comment should explain why we have to

[PATCH v2 3/8] document rwsem_release() in sb_wait_write()

Not only we need to avoid the warning from lockdep_sys_exit(), the caller of freeze_super() can never release this lock. Another thread can do this, so there is another reason for rwsem_release(). Plus the comment should explain why we have to fool lockdep. Signed-off-by: Oleg Nesterov ---

[PATCH v2 3/8] document rwsem_release() in sb_wait_write()

Not only we need to avoid the warning from lockdep_sys_exit(), the caller of freeze_super() can never release this lock. Another thread can do this, so there is another reason for rwsem_release(). Plus the comment should explain why we have to fool lockdep. Signed-off-by: Oleg Nesterov