Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

2015-01-12 Thread Alexandre Belloni
On 10/01/2015 at 17:14:00 -0800, Guenter Roeck wrote : > Not sure I understand what my comment has to do with 'parent'. > > The fact that the code checks if it has already been instantiated > suggests that the original author of the driver was concerned about > that case. Since you did not remove

Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

2015-01-10 Thread Guenter Roeck
On 01/10/2015 10:41 AM, Alexandre Belloni wrote: On 09/01/2015 at 16:39:21 -0800, Guenter Roeck wrote : On 01/09/2015 01:51 AM, Alexandre Belloni wrote: /* . */ @@ -204,6 +201,7 @@ static struct miscdevice at91wdt_miscde

Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

2015-01-10 Thread Alexandre Belloni
On 09/01/2015 at 16:39:21 -0800, Guenter Roeck wrote : > On 01/09/2015 01:51 AM, Alexandre Belloni wrote: > > /* > > . */ > >@@ -204,6 +201,7 @@ static struct miscdevice at91wdt_miscdev = { > > static int at91wdt_probe(struc

Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

2015-01-09 Thread Guenter Roeck
On 01/09/2015 01:51 AM, Alexandre Belloni wrote: The system timer MFD driver is providing a regmap. Use it to access the registers. Signed-off-by: Alexandre Belloni --- drivers/watchdog/Kconfig | 2 +- drivers/watchdog/at91rm9200_wdt.c | 27 +-- 2 files cha

[PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

2015-01-09 Thread Alexandre Belloni
The system timer MFD driver is providing a regmap. Use it to access the registers. Signed-off-by: Alexandre Belloni --- drivers/watchdog/Kconfig | 2 +- drivers/watchdog/at91rm9200_wdt.c | 27 +-- 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/