Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 12:20:36PM +0200, Miguel Ojeda wrote: > Hi Lars, Willy, > > On Tue, Sep 22, 2020 at 12:04 PM Willy Tarreau wrote: > > > > The points you mention are good enough indicators that it's extremely > > unlikely anyone has ever used that feature with these drivers. So I > >

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Miguel Ojeda
Hi Lars, Willy, On Tue, Sep 22, 2020 at 12:04 PM Willy Tarreau wrote: > > The points you mention are good enough indicators that it's extremely > unlikely anyone has ever used that feature with these drivers. So I > think it's best to keep your changes and wait to see if anyone pops > up with an

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Willy Tarreau
On Tue, Sep 22, 2020 at 11:44:22AM +0200, Lars Poeschel wrote: > On Tue, Sep 22, 2020 at 07:27:01AM +0200, Willy Tarreau wrote: > > On Mon, Sep 21, 2020 at 04:46:43PM +0200, poesc...@lemonage.de wrote: > > > From: Lars Poeschel > > > > > > Skip printing characters at the end of a display line.

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 07:27:01AM +0200, Willy Tarreau wrote: > On Mon, Sep 21, 2020 at 04:46:43PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > Skip printing characters at the end of a display line. This fits to the > > behaviour we already had, that the cursor is nailed

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-21 Thread Willy Tarreau
On Mon, Sep 21, 2020 at 04:46:43PM +0200, poesc...@lemonage.de wrote: > From: Lars Poeschel > > Skip printing characters at the end of a display line. This fits to the > behaviour we already had, that the cursor is nailed to last position of > a line. Just very old memories, but wasn't this

[PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-21 Thread poeschel
From: Lars Poeschel Skip printing characters at the end of a display line. This fits to the behaviour we already had, that the cursor is nailed to last position of a line. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/charlcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git