Re: [PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-19 Thread Vineet Gupta
On Saturday 19 January 2013 12:38 AM, Sam Ravnborg wrote: >> arch/arc/include/asm/vmlinux.lds.h | 12 ++ > I see no reason for this file? > >> . >> +#ifndef __ASM_VMLINUX_LDS_H__ >> +#define __ASM_VMLINUX_LDS_H__ >> + >> +#endif > It is empty. > Only sh provide one today (which is not empty).

Re: [PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-19 Thread Vineet Gupta
On Saturday 19 January 2013 12:34 AM, Sam Ravnborg wrote: >> +# >> + >> +config ARC >> +def_bool y >> +select ARCH_NO_VIRT_TO_BUS >> +# ARC Busybox based initramfs absolutely relies on DEVTMPFS for /dev >> +# DEVTMPS in turn needs HOTPLUG >> +select DEVTMPFS if !INITRAMFS_SOURCE

Re: [PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-18 Thread Arnd Bergmann
On Friday 18 January 2013, Sam Ravnborg wrote: > > +obj-y:= arcksyms.o setup.o irq.o time.o reset.o ptrace.o entry.o > > process.o \ > > +signal.o traps.o sys.o troubleshoot.o stacktrace.o clk.o > > For new stuff I usually recommend to drop line continuation using \ > > Just do t

Re: [PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-18 Thread Sam Ravnborg
> arch/arc/include/asm/vmlinux.lds.h | 12 ++ I see no reason for this file? > --- /dev/null > +++ b/arch/arc/include/asm/vmlinux.lds.h > @@ -0,0 +1,12 @@ > +/* > + * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (www.synopsys.com) > + * > + * This program is free software; you can r

Re: [PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-18 Thread Sam Ravnborg
> +# > + > +config ARC > + def_bool y > + select ARCH_NO_VIRT_TO_BUS > + # ARC Busybox based initramfs absolutely relies on DEVTMPFS for /dev > + # DEVTMPS in turn needs HOTPLUG > + select DEVTMPFS if !INITRAMFS_SOURCE="" > + select GENERIC_ATOMIC64 > + select GENERIC_CL

[PATCH v2 31/76] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-18 Thread Vineet Gupta
Arnd in his review pointed out that arch Kconfig organisation has several deficiencies: * Build time entries for things which can be runtime extracted from DT (e.g. SDRAM size, core clk frequency..) * Not multi-platform-image-build friendly (choice .. endchoice constructs) * cpu variants support