Re: [PATCH v2 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-04-16 Thread Iyappan Subramanian
Hi, Please find my response inline. On Mon, Apr 14, 2014 at 7:05 AM, Ben Dooks wrote: > On 12/04/14 04:06, Iyappan Subramanian wrote: >> >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel > > > [snip] > > >> +{ >

Re: [PATCH v2 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-04-14 Thread Iyappan Subramanian
Hi David, Thanks for the review comments. Please find my responses inline. Thanks, Iyappan On Sat, Apr 12, 2014 at 1:55 PM, David Miller wrote: > From: Iyappan Subramanian > Date: Fri, 11 Apr 2014 20:06:24 -0700 > >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off

Re: [PATCH v2 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-04-14 Thread Ben Dooks
On 12/04/14 04:06, Iyappan Subramanian wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel [snip] +{ + struct xgene_enet_pdata *pdata = netdev_priv(ndev); + struct phy_device *phydev; + unsigned c

Re: [PATCH v2 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-04-12 Thread David Miller
From: Iyappan Subramanian Date: Fri, 11 Apr 2014 20:06:24 -0700 > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar This driver is going to take a long to review and get to the point w