Re: [PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-29 Thread Chao Yu
On 2021/3/29 14:55, Gao Xiang wrote: I found a reference here, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v5.11#n99 also vaguely remembered some threads from Linus, but hard to find now :-( Sure, we can follow this rule for e

Re: [PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-28 Thread Gao Xiang
On Mon, Mar 29, 2021 at 02:43:48PM +0800, Chao Yu wrote: ... > > > > + > > > > +static int erofs_load_compr_cfgs(struct super_block *sb, > > > > +struct erofs_super_block *dsb) > > > > +{ > > > > + struct erofs_sb_info *sbi; > > > > + struct page *page;

Re: [PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-28 Thread Chao Yu
On 2021/3/29 14:36, Gao Xiang wrote: Hi Chao, On Mon, Mar 29, 2021 at 02:26:05PM +0800, Chao Yu wrote: On 2021/3/29 9:23, Gao Xiang wrote: From: Gao Xiang Add a bitmap for available compression algorithms and a variable-sized on-disk table for compression options in preparation for upcoming

Re: [PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-28 Thread Gao Xiang
Hi Chao, On Mon, Mar 29, 2021 at 02:26:05PM +0800, Chao Yu wrote: > On 2021/3/29 9:23, Gao Xiang wrote: > > From: Gao Xiang > > > > Add a bitmap for available compression algorithms and a variable-sized > > on-disk table for compression options in preparation for upcoming big > > pcluster and LZ

Re: [PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-28 Thread Chao Yu
On 2021/3/29 9:23, Gao Xiang wrote: From: Gao Xiang Add a bitmap for available compression algorithms and a variable-sized on-disk table for compression options in preparation for upcoming big pcluster and LZMA algorithm, which follows the end of super block. To parse the compression options,

[PATCH v2 4/4] erofs: add on-disk compression configurations

2021-03-28 Thread Gao Xiang
From: Gao Xiang Add a bitmap for available compression algorithms and a variable-sized on-disk table for compression options in preparation for upcoming big pcluster and LZMA algorithm, which follows the end of super block. To parse the compression options, the bitmap is scanned one by one. For