Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer

2021-01-25 Thread Troy Lee
Hi Guenter, The 01/24/2021 00:14, Guenter Roeck wrote: > On Wed, Jan 13, 2021 at 07:08:48AM +, Troy Lee wrote: > > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > > 16 FAN tacho channel. > > > > Changes since v1: > > - fixed review comments > > - fixed double-looped

Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer

2021-01-23 Thread Guenter Roeck
On Wed, Jan 13, 2021 at 07:08:48AM +, Troy Lee wrote: > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > 16 FAN tacho channel. > > Changes since v1: > - fixed review comments > - fixed double-looped calculation of div_h and div_l > - moving configuration to device

[PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer

2021-01-12 Thread Troy Lee
Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and 16 FAN tacho channel. Changes since v1: - fixed review comments - fixed double-looped calculation of div_h and div_l - moving configuration to device tree - register hwmon driver with devm_hwmon_device_register_with_info()