Re: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-05-02 Thread Jonathan Cameron
On 02/05/17 13:23, Eva Rachel Retuya wrote: > On Mon, May 01, 2017 at 01:42:29AM +0100, Jonathan Cameron wrote: > [...] >> Few minor bits inline... I'm a little bit in two minds about the >> holding up waiting for new data when using another trigger... >> >> Jonathan > [...] >>> static int adxl3

Re: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-05-02 Thread Eva Rachel Retuya
On Mon, May 01, 2017 at 02:24:27PM +0300, Andy Shevchenko wrote: [...] > One nit below. > FWIW: > Reviewed-by: Andy Shevchenko > > > +static irqreturn_t adxl345_trigger_handler(int irq, void *p) > > +{ > > + struct iio_poll_func *pf = p; > > + struct iio_dev *indio_dev = pf->indio_dev

Re: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-05-02 Thread Eva Rachel Retuya
On Mon, May 01, 2017 at 01:42:29AM +0100, Jonathan Cameron wrote: [...] > Few minor bits inline... I'm a little bit in two minds about the > holding up waiting for new data when using another trigger... > > Jonathan [...] > > static int adxl345_read_raw(struct iio_dev *indio_dev, > > @@ -127,6

Re: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-05-01 Thread Andy Shevchenko
On Sat, Apr 29, 2017 at 10:49 AM, Eva Rachel Retuya wrote: > Previously, the only way to capture data is to read the exposed sysfs > files in_accel_[x/y/z]_raw and applying the scale from in_accel_scale. > Provide a way for continuous data capture that allows multiple data > channels to be read at

Re: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-04-30 Thread Jonathan Cameron
On 29/04/17 08:49, Eva Rachel Retuya wrote: > Previously, the only way to capture data is to read the exposed sysfs > files in_accel_[x/y/z]_raw and applying the scale from in_accel_scale. > Provide a way for continuous data capture that allows multiple data > channels to be read at once by setting

[PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer

2017-04-29 Thread Eva Rachel Retuya
Previously, the only way to capture data is to read the exposed sysfs files in_accel_[x/y/z]_raw and applying the scale from in_accel_scale. Provide a way for continuous data capture that allows multiple data channels to be read at once by setting up buffer support. Initialize scan_type fields tha