Re: [PATCH v2 4/4] mm: Generalize putback scan functions

2019-02-18 Thread Kirill Tkhai
On 16.02.2019 01:13, Daniel Jordan wrote: > On Fri, Feb 15, 2019 at 10:01:05PM +, Kirill Tkhai wrote: >> On 15.02.2019 23:39, Daniel Jordan wrote: >>> On Thu, Feb 14, 2019 at 01:35:37PM +0300, Kirill Tkhai wrote: +static unsigned noinline_for_stack move_pages_to_lru(struct lruvec

Re: [PATCH v2 4/4] mm: Generalize putback scan functions

2019-02-15 Thread Daniel Jordan
On Fri, Feb 15, 2019 at 10:01:05PM +, Kirill Tkhai wrote: > On 15.02.2019 23:39, Daniel Jordan wrote: > > On Thu, Feb 14, 2019 at 01:35:37PM +0300, Kirill Tkhai wrote: > >> +static unsigned noinline_for_stack move_pages_to_lru(struct lruvec > >> *lruvec, > >> +

Re: [PATCH v2 4/4] mm: Generalize putback scan functions

2019-02-15 Thread Kirill Tkhai
On 15.02.2019 23:39, Daniel Jordan wrote: > On Thu, Feb 14, 2019 at 01:35:37PM +0300, Kirill Tkhai wrote: >> +static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, >> + struct list_head *list) >> { >> struct pglist_data *pg

Re: [PATCH v2 4/4] mm: Generalize putback scan functions

2019-02-15 Thread Daniel Jordan
On Thu, Feb 14, 2019 at 01:35:37PM +0300, Kirill Tkhai wrote: > +static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, > + struct list_head *list) > { > struct pglist_data *pgdat = lruvec_pgdat(lruvec); > + int nr_pag

[PATCH v2 4/4] mm: Generalize putback scan functions

2019-02-14 Thread Kirill Tkhai
This combines two similar functions move_active_pages_to_lru() and putback_inactive_pages() into single move_pages_to_lru(). This remove duplicate code and makes object file size smaller. Before: textdata bss dec hex filename 570824732 128 61942f1f6 mm/vmscan.o A