RE: [PATCH v2 4/4] net: phy: realtek: cleanup code

2013-05-12 Thread Jongsung Kim
Sergei Shtylyov : >> -.suspend= genphy_suspend, >> -.resume = genphy_resume, >> +.suspend= &genphy_suspend, >> +.resume = &genphy_resume, > >Contrariwise, you should have dropped & from the other functions. >It's

Re: [PATCH v2 4/4] net: phy: realtek: cleanup code

2013-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2013 11:29, Jongsung Kim wrote: This patch cleans up the drivers code by: - using a consistent way to reference functions - removing unused macro-definitions - removing unnecessary new-lines - making ack_interrupt functions shorter. Signed-off-by: Jongsung Kim --- drive

[PATCH v2 4/4] net: phy: realtek: cleanup code

2013-05-10 Thread Jongsung Kim
This patch cleans up the drivers code by: - using a consistent way to reference functions - removing unused macro-definitions - removing unnecessary new-lines - making ack_interrupt functions shorter. Signed-off-by: Jongsung Kim --- drivers/net/phy/realtek.c | 29 ++---