Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-24 Thread Junxiao Bi
On 11/25/2015 01:04 PM, Gang He wrote: > Hi Mark and Junxiao, > > >> Hi Mark, >> >> On 11/25/2015 06:16 AM, Mark Fasheh wrote: >>> Hi Junxiao, >>> >>> On Tue, Nov 03, 2015 at 03:12:35PM +0800, Junxiao Bi wrote: Hi Gang, This is not like a right patch. First, online file c

Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-24 Thread Gang He
Hi Mark and Junxiao, >>> > Hi Mark, > > On 11/25/2015 06:16 AM, Mark Fasheh wrote: >> Hi Junxiao, >> >> On Tue, Nov 03, 2015 at 03:12:35PM +0800, Junxiao Bi wrote: >>> Hi Gang, >>> >>> This is not like a right patch. >>> First, online file check only checks inode's block number, valid flag, >>

Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-24 Thread Junxiao Bi
Hi Mark, On 11/25/2015 06:16 AM, Mark Fasheh wrote: > Hi Junxiao, > > On Tue, Nov 03, 2015 at 03:12:35PM +0800, Junxiao Bi wrote: >> Hi Gang, >> >> This is not like a right patch. >> First, online file check only checks inode's block number, valid flag, >> fs generation value, and meta ecc. I nev

Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-24 Thread Mark Fasheh
Hi Junxiao, On Tue, Nov 03, 2015 at 03:12:35PM +0800, Junxiao Bi wrote: > Hi Gang, > > This is not like a right patch. > First, online file check only checks inode's block number, valid flag, > fs generation value, and meta ecc. I never see a real corruption > happened only on this field, if thes

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:47 PM, Gang He wrote: >> >> >> > >>> On 11/03/2015 04:15 PM, Gang He wrote: Hello Junxiao, See my comments inline. >>> > Hi Gang, > > This is not like a right patch. > First, online file check only checks inode's block n

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Junxiao Bi
On 11/03/2015 04:47 PM, Gang He wrote: > > > >> On 11/03/2015 04:15 PM, Gang He wrote: >>> Hello Junxiao, >>> >>> See my comments inline. >>> >>> >> Hi Gang, This is not like a right patch. First, online file check only checks inode's block number, valid flag, f

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:15 PM, Gang He wrote: >> Hello Junxiao, >> >> See my comments inline. >> >> > >>> Hi Gang, >>> >>> This is not like a right patch. >>> First, online file check only checks inode's block number, valid flag, >>> fs generation value, and meta ecc. I never see a real c

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Junxiao Bi
On 11/03/2015 04:15 PM, Gang He wrote: > Hello Junxiao, > > See my comments inline. > > >> Hi Gang, >> >> This is not like a right patch. >> First, online file check only checks inode's block number, valid flag, >> fs generation value, and meta ecc. I never see a real corruption >> happened

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
Hello Junxiao, See my comments inline. >>> > Hi Gang, > > This is not like a right patch. > First, online file check only checks inode's block number, valid flag, > fs generation value, and meta ecc. I never see a real corruption > happened only on this field, if these fields are corrupted, th

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-02 Thread Junxiao Bi
Hi Gang, This is not like a right patch. First, online file check only checks inode's block number, valid flag, fs generation value, and meta ecc. I never see a real corruption happened only on this field, if these fields are corrupted, that means something bad may happen on other place. So fix th

[PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-10-27 Thread Gang He
Implement online check or fix inode block during reading a inode block to memory. Signed-off-by: Gang He --- fs/ocfs2/inode.c | 196 +++-- fs/ocfs2/ocfs2_trace.h | 2 + 2 files changed, 192 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/i