Re: [PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Peter Zijlstra
On Wed, Mar 03, 2021 at 11:46:59AM +0800, Chengming Zhou wrote: > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > cgroups") only update cgroups whose state actually changes during a > task switch only in task preempt case, not in task sleep case. > > We actually don't need

Re: [External] Re: [PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Muchun Song
On Wed, Mar 3, 2021 at 11:53 PM Peter Zijlstra wrote: > > On Wed, Mar 03, 2021 at 11:46:59AM +0800, Chengming Zhou wrote: > > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > > cgroups") only update cgroups whose state actually changes during a > > task switch only in task p

Re: [PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Johannes Weiner
On Wed, Mar 03, 2021 at 11:46:59AM +0800, Chengming Zhou wrote: > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > cgroups") only update cgroups whose state actually changes during a > task switch only in task preempt case, not in task sleep case. > > We actually don't need

[PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Chengming Zhou
The commit 36b238d57172 ("psi: Optimize switching tasks inside shared cgroups") only update cgroups whose state actually changes during a task switch only in task preempt case, not in task sleep case. We actually don't need to clear and set TSK_ONCPU state for common cgroups of next and prev task