Re: [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex

On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote: > The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it > should be written as one. Semaphores are going away in the future. > _enter_pwrlock was using down_interruptible(), so the lock could be broken > by sending a sig

[PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex

The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. _enter_pwrlock was using down_interruptible(), so the lock could be broken by sending a signal. This could be a bug, because nothing checks the return code here