Re: [PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from *_notify function

2015-03-26 Thread Darren Hart
On Wed, Mar 25, 2015 at 04:18:19PM -0600, Azael Avalos wrote: > > That suggests to me the checks for rfkill, powered, and plugged states > > should be > > done in the _enable() function itself, rather than at all the call sites. > > > > So... would a better fix be to push these two additional test

Re: [PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from *_notify function

2015-03-25 Thread Azael Avalos
Hi Darren, 2015-03-25 15:24 GMT-06:00 Darren Hart : > On Wed, Mar 25, 2015 at 02:19:17PM -0600, Azael Avalos wrote: >> Bug 93911 reported a broken handling of the BT device, causing the >> driver to get stuck in a loop enabling/disabling the device whenever >> the device is deactivated by the kill

Re: [PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from *_notify function

2015-03-25 Thread Darren Hart
On Wed, Mar 25, 2015 at 02:19:17PM -0600, Azael Avalos wrote: > Bug 93911 reported a broken handling of the BT device, causing the > driver to get stuck in a loop enabling/disabling the device whenever > the device is deactivated by the kill switch as follows: > > 1. The user activated the kill sw

[PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from *_notify function

2015-03-25 Thread Azael Avalos
Bug 93911 reported a broken handling of the BT device, causing the driver to get stuck in a loop enabling/disabling the device whenever the device is deactivated by the kill switch as follows: 1. The user activated the kill switch, causing the system to generate a 0x90 (status change) event and