Re: [PATCH v2 4/5] ext4: add ext4_should_use_dax()

2017-10-12 Thread Theodore Ts'o
On Tue, Sep 12, 2017 at 08:46:12AM +0200, Jan Kara wrote: > On Mon 11-09-17 23:05:25, Ross Zwisler wrote: > > This helper, in the spirit of ext4_should_dioread_nolock() et al., replaces > > the complex conditional in ext4_set_inode_flags(). > > > > Signed-off-by: Ross Zwisler > > Yeah, makes sen

Re: [PATCH v2 4/5] ext4: add ext4_should_use_dax()

2017-09-11 Thread Jan Kara
On Mon 11-09-17 23:05:25, Ross Zwisler wrote: > This helper, in the spirit of ext4_should_dioread_nolock() et al., replaces > the complex conditional in ext4_set_inode_flags(). > > Signed-off-by: Ross Zwisler Yeah, makes sense to me. You can add: Reviewed-by: Jan Kara

[PATCH v2 4/5] ext4: add ext4_should_use_dax()

2017-09-11 Thread Ross Zwisler
This helper, in the spirit of ext4_should_dioread_nolock() et al., replaces the complex conditional in ext4_set_inode_flags(). Signed-off-by: Ross Zwisler --- fs/ext4/inode.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.