Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-18 Thread Jonathan Cameron
On 18/04/16 16:53, Andrew F. Davis wrote: > On 04/17/2016 11:56 PM, Alison Schofield wrote: >> On Sun, Apr 17, 2016 at 01:07:52PM -0500, Andrew F. Davis wrote: >>> On 04/16/2016 02:22 PM, Jonathan Cameron wrote: On 10/04/16 20:07, Alison Schofield wrote: > Driver includes struct regmap and

Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-18 Thread Andrew F. Davis
On 04/17/2016 11:56 PM, Alison Schofield wrote: > On Sun, Apr 17, 2016 at 01:07:52PM -0500, Andrew F. Davis wrote: >> On 04/16/2016 02:22 PM, Jonathan Cameron wrote: >>> On 10/04/16 20:07, Alison Schofield wrote: Driver includes struct regmap and struct device in its global data. Remove t

Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-17 Thread Alison Schofield
On Sun, Apr 17, 2016 at 01:07:52PM -0500, Andrew F. Davis wrote: > On 04/16/2016 02:22 PM, Jonathan Cameron wrote: > > On 10/04/16 20:07, Alison Schofield wrote: > >> Driver includes struct regmap and struct device in its global data. > >> Remove the struct device and use regmap API to retrieve dev

Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-17 Thread Andrew F. Davis
On 04/16/2016 02:22 PM, Jonathan Cameron wrote: > On 10/04/16 20:07, Alison Schofield wrote: >> Driver includes struct regmap and struct device in its global data. >> Remove the struct device and use regmap API to retrieve device info. >> Why? This adds nothing but more code to get dev through som

Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-16 Thread Jonathan Cameron
On 10/04/16 20:07, Alison Schofield wrote: > Driver includes struct regmap and struct device in its global data. > Remove the struct device and use regmap API to retrieve device info. > > Patch created using Coccinelle plus manual edits. > > Signed-off-by: Alison Schofield Cc'd Andrew > --- > d

[PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4404.c | 38 +++---