Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-25 Thread Honghui Zhang
On Tue, 2016-05-24 at 16:36 +0100, Robin Murphy wrote: > On 24/05/16 10:57, Honghui Zhang wrote: > [...] > >>> @@ -48,6 +48,9 @@ struct mtk_iommu_domain { > >>> struct io_pgtable_ops *iop; > >>> > >>> struct iommu_domain domain; > >>> + void

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-25 Thread Honghui Zhang
On Tue, 2016-05-24 at 16:36 +0100, Robin Murphy wrote: > On 24/05/16 10:57, Honghui Zhang wrote: > [...] > >>> @@ -48,6 +48,9 @@ struct mtk_iommu_domain { > >>> struct io_pgtable_ops *iop; > >>> > >>> struct iommu_domain domain; > >>> + void

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-24 Thread Robin Murphy
On 24/05/16 10:57, Honghui Zhang wrote: [...] @@ -48,6 +48,9 @@ struct mtk_iommu_domain { struct io_pgtable_ops *iop; struct iommu_domain domain; + void*pgt_va; + dma_addr_t pgt_pa; + void

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-24 Thread Robin Murphy
On 24/05/16 10:57, Honghui Zhang wrote: [...] @@ -48,6 +48,9 @@ struct mtk_iommu_domain { struct io_pgtable_ops *iop; struct iommu_domain domain; + void*pgt_va; + dma_addr_t pgt_pa; + void

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-24 Thread Honghui Zhang
Hi, Robin, Thanks very much for your comments. On Mon, 2016-05-23 at 20:31 +0100, Robin Murphy wrote: > On 19/05/16 12:49, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > Mediatek SoC's M4U has two generations of HW architcture. Generation one > >

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-24 Thread Honghui Zhang
Hi, Robin, Thanks very much for your comments. On Mon, 2016-05-23 at 20:31 +0100, Robin Murphy wrote: > On 19/05/16 12:49, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > Mediatek SoC's M4U has two generations of HW architcture. Generation one > > uses flat, one layer

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-23 Thread Robin Murphy
On 19/05/16 12:49, honghui.zh...@mediatek.com wrote: From: Honghui Zhang Mediatek SoC's M4U has two generations of HW architcture. Generation one uses flat, one layer pagetable, and was shipped with ARM architecture, it only supports 4K size page mapping. MT2701 SoC

Re: [PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-23 Thread Robin Murphy
On 19/05/16 12:49, honghui.zh...@mediatek.com wrote: From: Honghui Zhang Mediatek SoC's M4U has two generations of HW architcture. Generation one uses flat, one layer pagetable, and was shipped with ARM architecture, it only supports 4K size page mapping. MT2701 SoC uses this generation one

[PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-19 Thread honghui.zhang
From: Honghui Zhang Mediatek SoC's M4U has two generations of HW architcture. Generation one uses flat, one layer pagetable, and was shipped with ARM architecture, it only supports 4K size page mapping. MT2701 SoC uses this generation one m4u HW. Generation two uses

[PATCH v2 4/5] iommu/mediatek: add support for mtk iommu generation one HW

2016-05-19 Thread honghui.zhang
From: Honghui Zhang Mediatek SoC's M4U has two generations of HW architcture. Generation one uses flat, one layer pagetable, and was shipped with ARM architecture, it only supports 4K size page mapping. MT2701 SoC uses this generation one m4u HW. Generation two uses the ARM short-descriptor