Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-09 Thread James Bottomley
On Fri, 2014-05-09 at 14:19 -0600, Bjorn Helgaas wrote: > On Fri, May 9, 2014 at 1:52 PM, Arnd Bergmann wrote: > > On Friday 09 May 2014 09:32:26 Bjorn Helgaas wrote: > >> > There are people who care deeply about the performance of IOMMU API > >> > map/unmap. It isn't used *just* for virtual machi

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-09 Thread Bjorn Helgaas
On Fri, May 9, 2014 at 1:52 PM, Arnd Bergmann wrote: > On Friday 09 May 2014 09:32:26 Bjorn Helgaas wrote: >> > There are people who care deeply about the performance of IOMMU API >> > map/unmap. It isn't used *just* for virtual machines any more. See >> > drivers/infiniband/hw/usnic/usnic_uiom.c

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-09 Thread Arnd Bergmann
On Friday 09 May 2014 09:32:26 Bjorn Helgaas wrote: > > There are people who care deeply about the performance of IOMMU API > > map/unmap. It isn't used *just* for virtual machines any more. See > > drivers/infiniband/hw/usnic/usnic_uiom.c for example. > > Of course we should care about IOMMU API

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-09 Thread Bjorn Helgaas
On Fri, May 09, 2014 at 10:58:50AM +0100, David Woodhouse wrote: > On Thu, 2014-05-08 at 14:30 -0600, Bjorn Helgaas wrote: > > I doubt there would be a noticeable performance effect since these are > > relatively low-frequency interfaces (map, unmap, report_fault), > > That point of view makes me

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-09 Thread David Woodhouse
On Thu, 2014-05-08 at 14:30 -0600, Bjorn Helgaas wrote: > I doubt there would be a noticeable performance effect since these are > relatively low-frequency interfaces (map, unmap, report_fault), That point of view makes me sad. There are people who care deeply about the performance of IOMMU API

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-08 Thread Bjorn Helgaas
On Thu, May 08, 2014 at 12:44:12PM +0200, Arnd Bergmann wrote: > On Wednesday 07 May 2014 18:18:14 Bjorn Helgaas wrote: > > On Wed, May 07, 2014 at 09:58:58AM +0200, Arnd Bergmann wrote: > > > On Tuesday 06 May 2014 16:48:40 Bjorn Helgaas wrote: > > > > Convert the "iova" arguments of iommu_map(),

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-08 Thread Arnd Bergmann
On Wednesday 07 May 2014 18:18:14 Bjorn Helgaas wrote: > On Wed, May 07, 2014 at 09:58:58AM +0200, Arnd Bergmann wrote: > > On Tuesday 06 May 2014 16:48:40 Bjorn Helgaas wrote: > > > Convert the "iova" arguments of iommu_map(), iommu_unmap(), etc., from > > > "unsigned long" to dma_addr_t. > > > >

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-07 Thread Bjorn Helgaas
On Wed, May 07, 2014 at 09:58:58AM +0200, Arnd Bergmann wrote: > On Tuesday 06 May 2014 16:48:40 Bjorn Helgaas wrote: > > Convert the "iova" arguments of iommu_map(), iommu_unmap(), etc., from > > "unsigned long" to dma_addr_t. > > > > bb5547acfcd8 ("iommu/fsl: Make iova dma_addr_t in the iommu_io

Re: [PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-07 Thread Arnd Bergmann
On Tuesday 06 May 2014 16:48:40 Bjorn Helgaas wrote: > Convert the "iova" arguments of iommu_map(), iommu_unmap(), etc., from > "unsigned long" to dma_addr_t. > > bb5547acfcd8 ("iommu/fsl: Make iova dma_addr_t in the iommu_iova_to_phys > API") did this for iommu_iova_to_phys(), but didn't fix the

[PATCH v2 4/5] iommu: Use dma_addr_t for IOVA arguments

2014-05-06 Thread Bjorn Helgaas
Convert the "iova" arguments of iommu_map(), iommu_unmap(), etc., from "unsigned long" to dma_addr_t. bb5547acfcd8 ("iommu/fsl: Make iova dma_addr_t in the iommu_iova_to_phys API") did this for iommu_iova_to_phys(), but didn't fix the rest of the IOMMU API. This changes the following generic func